| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
It's pointless to show the popout action when splitscreen is closed,
so we'll remove it as a child of the splitscreen action whenever the
screen is not split.
|
|
Now that it's a KMenuAction, it becomes impossible to trigger the root
action when it's in a menu. To work around this, we create a new action
that mirrors the state of the original. It also takes the default
shortcut.
|
|
|
|
|
|
|
|
|
|
If you have a split view open, you can now pop the active half out into a new window by clicking the "Pop out" button in the toolbar or by activating "View > Pop out".
BUG: 270604
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
|
|
BUG: 441070
|
|
Commit d27ee07d makes it impossible for applications embedding Dolphin part (for example, Konqueror) to react to middle mouse click on a file. If I understand correctly (I'm not familiar with Dolphin code) the `fileMiddleClickActivated` signal is connected with a slot in `DolphinViewContainer`, which is only used by Dolphin itself and not by `DolphinPart`. The result is that middle clicking on a file (except archives) from a Dolphin part has no effect.
To avoid this situation, I removed the check for `!archiveProtocolIsEmpty()` in the `else if` condition. This way, if `isTabsForFilesEnabled()` is `true`, which should be true if and only if the view is inside a `DolphinPart`, the `activeTabRequested` or `tabRequested` signal will be emitted, allowing the embedding application to respond however it wants. When the view is inside the Dolphin application, instead, `isTabsForFilesEnabled()` will always be `false`, so the new behavior will be used.
|
|
Adds a simple test to check if session is autosaved when a new tab is
opened.
|
|
A minor refactor where Qt::SingleShotConnection has been utilized.
Also, signal delay using QTimer has been replaced with a
Qt::QueuedConnection.
|
|
Currently, the session is saved only when the app quits normally. Save
the session after a fixed time interval from the last state change i.e.
anytime the url is changed, or a tab is opened or closed, or the active
view is changed.
BUG: 425627
|
|
BUG: 475805
|
|
Since now when duplicating items we automatically generate a name for the new item, we can do the same if an item with that name already exists.
BUG: 475410
|
|
BUG: 469316
|
|
This is to make sure that users do not have to guess why they would
want to press the button.
|
|
No need for spellchecking when renaming folders/filenames.
BUG:477897
|
|
If Dolphin terminal is open, and one types `exit` there and then closes Dolphin, Dolphin crashes due to a dangling pointer.
Konsole KPart is deleting itself when Konsole session exits, but Dolphin tracks it as a child of the Terminal Panel.
The Terminal Panel doesn't get destroyed when Konsole KPart does, and it tries to double free during children clean up.
(Thanks @sitter !)
Setting `m_konsolePart` to `nullptr` during exit signal fixes this, since there is already check in place for that in the destructor.
BUG:479596
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
NO_CHANGELOG
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
|
|
It is related to receiving updates from dbus; but that's removed.
Also, it defaults to true
|
|
|
|
|
|
See https://invent.kde.org/plasma/breeze/-/merge_requests/390 for
explanation and screenshots
|
|
Fix "appstreamcli validate --explain" issue
"I: org.kde.dolphin.desktop:~: desktop-app-launchable-omitted
This `desktop-application` component has no `desktop-id` launchable tag,
however it contains all
the necessary information to display the application. The omission of the
launchable entry means
that this application can not be launched directly from installers or
software centers. If this
is intended, this information can be ignored, otherwise it is strongly
recommended to add a
launchable tag as well.".
|
|
|
|
variable depending on config
|
|
This reverts commit 9a2fc1526c169fa179e49f8c097a0a0d421723eb.
|
|
Proposed by krop on #kde-devel
Unless my bisect skills failed broken by https://gitlab.kitware.com/cmake/cmake/-/commit/ebc9e448b38378cc21a6b77df03a77d9732c24ac
|
|
compat code
Amends 3f92ac800c5e52d0a5622367ff8ffe8cbbdfa184
|
|
|
|
|
|
|
|
Fix issues e.g. "error: ‘QString::QString(const QByteArray&)’
is private within this context".
|
|
|
|
Read Felix' comment here: https://invent.kde.org/system/dolphin/-/merge_requests/679#note_835657
In short:
> The above change moves the `m_view->setFocus()` towards a point in time in
> which `DolphinViewContainer`'s selection mode state is consistent again.
BUG:478724
|
|
BUG: 476670
|
|
After refreshing the view when
size count is selected as the sortRole,
count is 0 at first. When the actual count is loaded,
the sorting is done according to the count being 0.
This can break the sort order and cause view and model
to be out of sync.
Making sure we always resort all items
when the directory size/item count is changed fixes this
BUG:473999
|
|
Related to https://invent.kde.org/system/dolphin/-/merge_requests/675
Reduces the delay for sorting items when something changes
|
|
Panels are unlocked even they're set locked in settings at start of the app.
This sets panels locked according to the setting.
BUG:478117
|
|
|
|
Fixes a weird bug with the treeview if one has
```
[PreviewSettings]
Plugins=audiothumbnail
```
in their `dolphinrc`. It can be any PreviewSettings plugin, as long as there it at least one.
Check the bug report for more, but in short, the bug is reproducible like this:
```
create folder tree inside a test folder with
mkdir -p 1/A/B/C/D/E/F/G/H/I
mkdir -p 2/A/B/C/D/E/F/G/H/I
mkdir -p 3/A/B/C/D/E/F/G/H/I
make sure you see the test folder, and expand it
expand folder 1, no need to expand all sub folders
expand folder 2
collapse and expand test folder
3 loses its expansion arrow
if all folders are expanded, only 3 keeps its order
if 1 and all its subfolders are expanded, then test is toggled,
folder 2 also loses its expansion arrow
```
Video of the bug:
The path to the bug is: `KFileItemModelRolesUpdater::slotPreviewFailed` -> `KFileItemModelRolesUpdater::applyResolvedRoles` -> `KFileItemModelRolesUpdater::rolesData` -> `KFileItemModelRolesUpdater::startDirectorySizeCounting`.
This causes Dolphin with preview plugins enabled trying to count the directories again, and the data gets reset even if there is something there. This then resets the `isExpandable` flag and that breaks the treeview, causing all kinds of issues, like being able to expand non-directories and makes things out of sync.
BUG:477607
|
|
Capturing an index is unsafe as it could be out of date when this is
processed. The user could have changed directory inserted a file or
changed sorting order.
|
|
(cherry picked from commit beb28a4bdeac3b2b0eb6ca559acfeca9af1b530e)
|
