┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2023-02-23Fix header index are colIndex and not roleIndexMéven Car
2023-02-21Fix typo in m_hoveredColumnHearderRoleIndexAleix Pol
2023-02-21Fix uninitialised valueAleix Pol
Do not read m_hoveredColumnHearderRoleIndex before it has been initialised. .6 0x00007fe00632182c in QList<KFileItemModel::RoleInfo>::Node::t (this=<optimized out>, this=<optimized out>) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h:153 .7 QList<KFileItemModel::RoleInfo>::at (i=3080252, this=0x7ffdf2e9bba8) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h:572 .8 DolphinView::eventFilter (this=0x5584bef25160, watched=0x5584bef8a300, event=0x7ffdf2e9bd30) at ./src/views/dolphinview.cpp:978 .9 0x00007fe003ebbdda in QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) () from /lib/x86_64-linux-gnu/libQt5Core.so.5 .10 0x00007fe004b6c782 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5 .11 0x00007fe004b75411 in QApplication::notify(QObject*, QEvent*) () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5 .12 0x00007fe003ebc07a in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /lib/x86_64-linux-gnu/libQt5Core.so.5 .13 0x00007fe004b72269 in QApplication::event(QEvent*) () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5 .14 0x00007fe004b6c793 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5 .15 0x00007fe003ebc07a in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /lib/x86_64-linux-gnu/libQt5Core.so.5 .16 0x00007fe003f14e0b in QTimerInfoList::activateTimers() () from /lib/x86_64-linux-gnu/libQt5Core.so.5 .17 0x00007fe003f15754 in ?? () from /lib/x86_64-linux-gnu/libQt5Core.so.5 .18 0x00007fe001d20d3b in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 .19 0x00007fe001d756c8 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 .20 0x00007fe001d1e3e3 in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 .21 0x00007fe003f15ad8 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /lib/x86_64-linux-gnu/libQt5Core.so.5 .22 0x00007fe003eba99b in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /lib/x86_64-linux-gnu/libQt5Core.so.5 .23 0x00007fe003ec2f34 in QCoreApplication::exec() () from /lib/x86_64-linux-gnu/libQt5Core.so.5 .24 0x00005584bd2a9aad in main (argc=<optimized out>, argv=<optimized out>) at ./src/main.cpp:249 BUG: 466110
2023-02-18DolphinView: Allow to have tootips on columns headersMéven Car
Add events columnHovered/columnUnHovered to KItemListview and KItemListHeaderWidget.
2023-02-15Allow empty metadata for KOverlayIconPluginAlexander Lohnau
We do not read the metadata anywhere, consequently we can allow empty metadata. Consumers now don't have to provide a file and we do no spend time parsing the JSON. Task: https://phabricator.kde.org/T14538
2023-02-15Consistent naming in tooltipsYuri Chornoivan
2023-02-14Fix a disconnect warningMéven Car
NO_CHANGELOG
2023-02-14Add new settings for permissions column formatSerg Podtynnyi
Ability to configure column for the file/dir permissions in Numeric(Octal)/Textual/Combined style and update field display style to be right-alighed. Add toolips to column menu items BUG: 227745
2023-02-14Revert "Remove deprecated ConfigurePreviewPluginDialog"Méven Car
This reverts commit d8de1c37e525580143c60bcd16aee3e7640890f1.
2023-02-14Revert "Remove deprecated KServiceTypeTrader"Méven Car
This reverts commit 648c2db6e4c6552962c20d2f9e4d3ce44e02d212.
2023-02-14Fix 'Show Target' for non-local URLsNicolas Fella
Links are not always local files, e.g. 'remote:/zeroconf' links to 'zeroconf:/' The current code fails there Instead of using QFile API that does not work on non-local URLs use QUrl::resolved to resolve relative links Furthermore, QFile::exists doesn't work for non-local URLs. Instead do a KIO stat to check whether the target exists
2023-02-12Optimize Directory size countingMéven Car
Two changes: * Prioritise size counting for visible path * stop the worker when switching dirs
2023-02-12SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-02-12GIT_SILENT made messages (after extraction)l10n daemon script
2023-02-10Remove deprecated KServiceTypeTraderDāvis Mosāns
2023-02-10Remove deprecated ConfigurePreviewPluginDialogDāvis Mosāns
2023-02-09Fix zooming for high resolution scroll wheelsFriso Smit
BUG: 432671
2023-02-09Reveal the Backspace shortcut in the UIForest ix
Since the Back action already has two standard shortcuts, a third one appended to the list will be invisible in the UI, which shows only the first two. This leaves users unable to reassign it. We therefore make it the first shortcut in the list, so that the hidden third entry will be the dedicated Back button, which users are far less likely to want reassigned. BUG: 371130
2023-02-09KFileItemModelRolesUpdater: Skip directory item count if it isSlow()Andrew Gunnerson
This makes the behavior of kernel cifs/nfs mounts the same as with kio's smb://. It also helps reduce the chance of the UI hanging due to opendir/readdir slowing down stat calls on the UI thread. Signed-off-by: Andrew Gunnerson <[email protected]>
2023-02-09Avoid crash on start when help actions are restricted through the Kiosk systemAlexander Volkov
This was first applied in 0ac57fbe90d580a514c3bac4cefaa9ed87f178f9, but then "reverted" in 3ccdcc2176bc5e4e03f733c21d05a5a4b0c1af25 by misunderstanding.
2023-02-06Selects next item in list after delete/trash actionsSerg Podtynnyi
BUG: 419914 BUG: 181214
2023-02-05Add clang-format and format code as in FrameworksSerg Podtynnyi
2023-02-04Add Page count and Publisher columnsSerg Podtynnyi
BUG: 374561
2023-02-01dolphinview: Fix right click broken on placeholderLabelDavide Garberi
* This commit fixes the right click context menu not being shown whenever the click is made right on the placeholderLabel text Signed-off-by: Davide Garberi <[email protected]>
2023-01-30SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-01-30GIT_SILENT made messages (after extraction)l10n daemon script
2023-01-29GIT_SILENT Update Appstream for new releaseHeiko Becker
(cherry picked from commit dd7a4fc0e842537b91bacb66f8fbade86fe457a5)
2023-01-29Fix sudo messageBharadwaj Raju
We don't have KIO PolKit support yet
2023-01-28GIT_SILENT made messages (after extraction)l10n daemon script
2023-01-25Clear filter bar on clicking current folder in placesSerg Podtynnyi
Reset the filter bar when user clicks on the current folder in places list, also rename slot function to be more clear. BUG: 259382
2023-01-22SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-01-22GIT_SILENT made messages (after extraction)l10n daemon script
2023-01-19Use both split view names in tab namesOliver Beard
When the tab is a split view, use the name of both views rather than only the active view.
2023-01-16Replace qswap with std::swapWillyanto Willyanto
Fixes obsolete function 'qSwap' called. It is recommended to use 'std::swap' instead. (CWE-477)
2023-01-15Add missing KCodecs linkNicolas Fella
2023-01-12Update split action when settings changeKai Uwe Broulik
In case "closing split view closes active view" setting is changed
2023-01-11Adapt autotest to new expected "Space" key behaviourFelix Ernst
The old expected behaviour was that pressing Space would select the current item. We now trigger selection mode instead and don't select. At some point in the future we might want to instead have Space trigger a "QuickLook" feature for quick viewing of full files. In any case, the old behaviour of having Space select is no longer expected, but Ctrl+Space can still be used for this. It might also make sense to have Space trigger the old selection behaviour if both selection mode and "QuickLook" are disabled, but that is very low priority and will cause more code complexity than the non-default benefits are worth.
2023-01-11Make space shortcut for selection mode view-local instead of globalFelix Ernst
Before this commit, the "Space" keyboard shortcut was bound to triggering selection mode by default. After this commit, pressing "Space" will only trigger selection mode when the file view area has keyboard focus. Pros: + Other buttons in the UI can be triggered with Space once again just like it is expected from an accessibility point of view. + "Type-ahead" searching works once more when typing the space char for file names containing such a space char. Cons: - "Space" can no longer be used to add the currently underlined item to the selection. Instead "Ctrl+Space" needs to be used. (However, this is the current status anyway unless a user has manually unbound "Space" as a shortcut from Selection Mode.) - The Selection Mode action will no longer show "Space" as its shortcut in menus. Overall, I see solutions to all of these problems, but they seem over-engineered for the issues they are trying to solve, so I believe this somewhat small commit is the best solution for now. BUG: 458282 BUG: 458281 CCBUG: 463048 FIXED-IN: 23.04
2023-01-09Remove unnecessary method parameterFabian Vogt
(cherry picked from commit ee919ea329ace516fb67468fa2d3c98bf46a66d2)
2023-01-09Fix size of directories if a subdir fails to openFabian Vogt
If opening the directory fails, it returns -1 as size. Don't add that to the parent's total size. (cherry picked from commit a6490755ca7d00c964a1349443ba9c06dbb33e50)
2023-01-09Don't recurse into symlinks when counting directory contentsFabian Vogt
Symlink contents should not be visited for the purpose of displaying sizes. Not only is potentially misleading because the storage is actually used elsewhere (the target location), it can be completely wrong as contents can be visited multiple times, even recursively. BUG: 434125 (cherry picked from commit 491068a4405f93ce66d4f49fa5ba5dee29e9546b)
2023-01-08Fix potential nullptr de-referenceFelix Ernst
The `break` that is replaced by a `return` here would only break out of the innermost while loop so the std::vector::end could still become accessed after that. By returning here we completely exit out of both nested loops and therefore don't access the std::vector::end.
2023-01-03GIT_SILENT Update Appstream for new releaseAlbert Astals Cid
(cherry picked from commit 28f49e6b913ab12f764f22b59a8340f3040e280c)
2023-01-02SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-01-02GIT_SILENT made messages (after extraction)l10n daemon script
2022-12-30Properly use X11 startup idsNicolas Fella
When one instance of Dolphin activates another it passes a startupId (X11) / activation token (wayland) along. On X11 this is passed using the DESKTOP_STARTUP_ID environment variable. The code tries to read that through KStartupInfo::startupId(). That doesn't work though, since Qt at startup reads the environment variable afterwards. However, it is nice enough to allow us to access it through QX11Info::nextStartupId(). Use that to read the token in the first instance and pass it to the second instance like we do on Wayland The user-facing impact of this is minimal since KStartupInfo::setNewStartupId internally falls back to KWindowSystem::forceActiveWindow when no startupId is passed.
2022-12-30SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2022-12-28SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2022-12-28GIT_SILENT made messages (after extraction)l10n daemon script
2022-12-26Not use forward and includesLaurent Montel
generated by cgit v1.3 (git 2.53.0) at 2026-04-20 17:31:04 +0000