┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlexander Lohnau <[email protected]>2020-10-24 16:46:34 +0200
committerAlexander Lohnau <[email protected]>2020-10-24 16:46:34 +0200
commit2448f88c5f42d7a2040fcf3bcd3c5f2a2f62cd03 (patch)
tree7a9164be1621a4c5696e776be299293ad1f1da60
parent97415729c34851df75c77a67f27d6299c00bfbc4 (diff)
Use mutable iterators where required
-rw-r--r--src/kitemviews/kfileitemmodel.cpp4
-rw-r--r--src/kitemviews/kfileitemmodelrolesupdater.cpp4
-rw-r--r--src/kitemviews/kitemlistview.cpp5
3 files changed, 10 insertions, 3 deletions
diff --git a/src/kitemviews/kfileitemmodel.cpp b/src/kitemviews/kfileitemmodel.cpp
index b89fe4f58..08407d1ef 100644
--- a/src/kitemviews/kfileitemmodel.cpp
+++ b/src/kitemviews/kfileitemmodel.cpp
@@ -917,7 +917,9 @@ void KFileItemModel::slotCompleted()
// Note that the parent folder must be expanded before any of its subfolders become visible.
// Therefore, some URLs in m_restoredExpandedUrls might not be visible yet
// -> we expand the first visible URL we find in m_restoredExpandedUrls.
- for (const QUrl& url : qAsConst(m_urlsToExpand)) {
+ QMutableSetIterator<QUrl> it(m_urlsToExpand);
+ while (it.hasNext()) {
+ const QUrl url = it.next();
const int indexForUrl = index(url);
if (indexForUrl >= 0) {
m_urlsToExpand.remove(url);
diff --git a/src/kitemviews/kfileitemmodelrolesupdater.cpp b/src/kitemviews/kfileitemmodelrolesupdater.cpp
index b9c6ccd29..8f3ddceed 100644
--- a/src/kitemviews/kfileitemmodelrolesupdater.cpp
+++ b/src/kitemviews/kfileitemmodelrolesupdater.cpp
@@ -943,7 +943,9 @@ void KFileItemModelRolesUpdater::updateChangedItems()
QList<int> visibleChangedIndexes;
QList<int> invisibleChangedIndexes;
- for (const KFileItem& item : qAsConst(m_changedItems)) {
+ QMutableSetIterator<KFileItem> it(m_changedItems);
+ while (it.hasNext()) {
+ const KFileItem item = it.next();
const int index = m_model->index(item);
if (index < 0) {
diff --git a/src/kitemviews/kitemlistview.cpp b/src/kitemviews/kitemlistview.cpp
index 3103012a9..4ed0d7ba4 100644
--- a/src/kitemviews/kitemlistview.cpp
+++ b/src/kitemviews/kitemlistview.cpp
@@ -1155,7 +1155,10 @@ void KItemListView::slotItemsRemoved(const KItemRangeList& itemRanges)
QVector<int> itemsToMove;
// Remove all KItemListWidget instances that got deleted
- for (KItemListWidget* widget : qAsConst(m_visibleItems)) {
+ QMutableHashIterator<int, KItemListWidget*> it(m_visibleItems);
+ while (it.hasNext()) {
+ it.next();
+ KItemListWidget* widget = it.value();
const int i = widget->index();
if (i < firstRemovedIndex) {
continue;