diff options
| author | Sebastian Englbrecht <[email protected]> | 2026-05-26 21:04:40 +0200 |
|---|---|---|
| committer | Méven Car <[email protected]> | 2026-05-28 08:56:45 +0000 |
| commit | 3779fbb7c9f1b22ebc9c61bfcdca42678463b164 (patch) | |
| tree | 66e1fb109ef139374575c7afe6756b325b8c1c34 | |
| parent | e17e6b84248119f878f34d246b68434b208aa8d5 (diff) | |
KItemListController: remove redundant conditions in drag/release handlers
newHoveredWidget is already guarded non-null by the enclosing if-block;
!isAboveSelectionToggle is always true after the preceding early return.
Remove both dead sub-expressions.
| -rw-r--r-- | src/kitemviews/kitemlistcontroller.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/kitemviews/kitemlistcontroller.cpp b/src/kitemviews/kitemlistcontroller.cpp index e87ed3c18..3250e570a 100644 --- a/src/kitemviews/kitemlistcontroller.cpp +++ b/src/kitemviews/kitemlistcontroller.cpp @@ -873,7 +873,7 @@ bool KItemListController::dragMoveEvent(QGraphicsSceneDragDropEvent *event, cons } else { m_autoActivationTimer->stop(); - if (newHoveredWidget && newHoveredWidget->isHovered()) { + if (newHoveredWidget->isHovered()) { newHoveredWidget->setHovered(false); Q_EMIT itemUnhovered(index); } @@ -1807,7 +1807,7 @@ bool KItemListController::onRelease(const QPointF &pos, const Qt::KeyboardModifi return true; } - if (!isAboveSelectionToggle && m_selectionTogglePressed) { + if (m_selectionTogglePressed) { m_selectionManager->setSelected(m_pressedIndex.value_or(-1), 1, KItemListSelectionManager::Toggle); m_selectionTogglePressed = false; return true; |
