┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIsmael Asensio <[email protected]>2019-10-03 22:00:24 +0200
committerElvis Angelaccio <[email protected]>2019-10-03 22:14:41 +0200
commit3d65fa9a79593166f9dff25d9977b93d1be03a98 (patch)
tree997322a3a021577acb7433f9e55338357404da72
parentc71c1c94be2e5ab2e14162a15780d4d12bee307b (diff)
Update searchbox on URL changes (Fix D24369)
Summary: In D24369 I introduced a regression: Where now the searchbox is updated on url changes for search urls, it is not updated anymore for regular folders. The effect is that not-indexed folders can have the extra options enabled or vice-versa. This patch fixes it, moving back the updating logic to `setSearchModeEnable`. Test Plan: - Searchbox updates properly when changing between search urls and regular folders, either indexed or nor-indexed. Reviewers: #dolphin, elvisangelaccio Subscribers: kfm-devel, elvisangelaccio Tags: #dolphin Differential Revision: https://phabricator.kde.org/D24376
-rw-r--r--src/dolphinviewcontainer.cpp13
1 files changed, 7 insertions, 6 deletions
diff --git a/src/dolphinviewcontainer.cpp b/src/dolphinviewcontainer.cpp
index 98b812497..13b88f601 100644
--- a/src/dolphinviewcontainer.cpp
+++ b/src/dolphinviewcontainer.cpp
@@ -385,6 +385,11 @@ bool DolphinViewContainer::isFilterBarVisible() const
void DolphinViewContainer::setSearchModeEnabled(bool enabled)
{
+ if (enabled) {
+ const QUrl& locationUrl = m_urlNavigator->locationUrl();
+ m_searchBox->fromSearchUrl(locationUrl);
+ }
+
if (enabled == isSearchModeEnabled()) {
if (enabled && !m_searchBox->hasFocus()) {
m_searchBox->setFocus();
@@ -673,15 +678,11 @@ void DolphinViewContainer::slotUrlNavigatorLocationChanged(const QUrl& url)
slotReturnPressed();
if (KProtocolManager::supportsListing(url)) {
- const bool searchUrl = isSearchUrl(url);
- if (searchUrl) {
- m_searchBox->fromSearchUrl(url);
- }
- setSearchModeEnabled(searchUrl);
+ setSearchModeEnabled(isSearchUrl(url));
m_view->setUrl(url);
tryRestoreViewState();
- if (m_autoGrabFocus && isActive() && !searchUrl) {
+ if (m_autoGrabFocus && isActive() && !isSearchUrl(url)) {
// When an URL has been entered, the view should get the focus.
// The focus must be requested asynchronously, as changing the URL might create
// a new view widget.