dolphinviewcontainer: do not implicitly open directories as files

we already have xdg-run, we don't need another runner interface ;)

notably if the user disabled the ask-before-execute guard rail from KIO,
they would also implicitly allow other applications to execute any file
by invoking it through dolphin, that would be a bit silly and isn't the
point of the guard rail opt-out.

when detecting a file we now instead open the parent

Should improve
CCBUG: 516830

1 files changed, 1 insertions, 9 deletions

diff --git a/src/dolphinviewcontainer.cpp b/src/dolphinviewcontainer.cpp
index e69383804..1126b992d 100644
--- a/src/dolphinviewcontainer.cpp
+++ b/src/dolphinviewcontainer.cpp
@@ -730,15 +730,7 @@ void DolphinViewContainer::slotUrlIsFileError(const QUrl &url)
 {
     const KFileItem item(url);
 
-    // Find out if the file can be opened in the view (for example, this is the
-    // case if the file is an archive). The mime type must be known for that.
-    item.determineMimeType();
-    const QUrl &folderUrl = DolphinView::openItemAsFolderUrl(item, true);
-    if (!folderUrl.isEmpty()) {
-        setUrl(folderUrl);
-    } else {
-        slotItemActivated(item);
-    }
+    setUrl(KIO::upUrl(item.url()));
 }
 
 void DolphinViewContainer::slotItemActivated(const KFileItem &item)