┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFrank Reininghaus <[email protected]>2013-02-03 23:28:57 +0100
committerFrank Reininghaus <[email protected]>2013-02-03 23:28:57 +0100
commit687d5145a25b99255065035ec63f3a29c711367d (patch)
tree8226b3eacdbb7e14331b8bb9041b4a8a41e0915f
parent01dc86f0dfdfe9b27c228d7f0c39c1b6585ccbe9 (diff)
Two small optimizations in KFileItemModel::removeItems()
1. It seems that it really can happen that KFileItems that we get from the dir lister's itemsDeleted signal are not in the model any more, e.g., if a folder where hidden files are shown is left and a folder where hidden files are not shown is entered. There is no need to output warnings then. 2. Remove the emptiness-check for the KFileItemList at the beginning. Even in the unlikely event that we do get an empty list, we return just a few lines later in the code.
-rw-r--r--src/kitemviews/kfileitemmodel.cpp6
1 files changed, 0 insertions, 6 deletions
diff --git a/src/kitemviews/kfileitemmodel.cpp b/src/kitemviews/kfileitemmodel.cpp
index a30e30e0f..e315eee50 100644
--- a/src/kitemviews/kfileitemmodel.cpp
+++ b/src/kitemviews/kfileitemmodel.cpp
@@ -1031,10 +1031,6 @@ static KItemRangeList sortedIndexesToKItemRangeList(const QList<int>& sortedNumb
void KFileItemModel::removeItems(const KFileItemList& items)
{
- if (items.isEmpty()) {
- return;
- }
-
#ifdef KFILEITEMMODEL_DEBUG
kDebug() << "Removing " << items.count() << "items";
#endif
@@ -1059,8 +1055,6 @@ void KFileItemModel::removeItems(const KFileItemList& items)
ItemData* data = m_itemData.at(index);
delete data;
m_itemData[index] = 0;
- } else {
- kWarning() << "Item that should be deleted has not been found!";
}
}