dolphinview: do not get view properties if we do not apply dynamic view

If we have return early because dynamic view is not enabled
or we have Icon View already, then do not try to load view
properties to get 'dynamicViewPassed' property.

Otherwise, for example, it infinitely calls
the ViewProperties::save() method for the /tmp folder,
which generates a bunch of temporary files
(on new user, if dynamic view is not enabled
and Icon View applied by default)

BUG: 508402

1 files changed, 6 insertions, 2 deletions

diff --git a/src/views/dolphinview.cpp b/src/views/dolphinview.cpp
index 6297efafe..729583ab0 100644
--- a/src/views/dolphinview.cpp
+++ b/src/views/dolphinview.cpp
@@ -2414,13 +2414,17 @@ void DolphinView::applyModeToView()
 
 void DolphinView::applyDynamicView()
 {
-    ViewProperties props(viewPropertiesUrl());
     /* return early if:
      * - dynamic view is not enabled
      * - the current view mode is already Icon View
      * - dynamic view has previously changed the view mode
      */
-    if (!GeneralSettings::dynamicView() || m_mode == IconsView || props.dynamicViewPassed()) {
+    if (!GeneralSettings::dynamicView() || m_mode == IconsView) {
+        return;
+    }
+
+    ViewProperties props(viewPropertiesUrl());
+    if (props.dynamicViewPassed()) {
         return;
     }