diff options
| author | Kai Uwe Broulik <[email protected]> | 2026-02-07 09:41:58 +0100 |
|---|---|---|
| committer | Kai Uwe Broulik <[email protected]> | 2026-02-07 09:41:58 +0100 |
| commit | 9bb9040c3fe541b29130ab50907d5c5134040271 (patch) | |
| tree | 9f568cca7407766fec8c129795777525f84cefc1 | |
| parent | 9f9d87483a45e6d30968a08f0f6029076d561c03 (diff) | |
Remove preview ignore maximum local size handling from Dolphin
This all seems to be done by the PreviewJob in KIO already.
| -rw-r--r-- | src/kitemviews/kfileitemlistview.cpp | 12 | ||||
| -rw-r--r-- | src/kitemviews/kfileitemlistview.h | 11 | ||||
| -rw-r--r-- | src/kitemviews/kfileitemmodelrolesupdater.cpp | 14 | ||||
| -rw-r--r-- | src/kitemviews/kfileitemmodelrolesupdater.h | 12 | ||||
| -rw-r--r-- | src/views/dolphinitemlistview.cpp | 1 |
5 files changed, 0 insertions, 50 deletions
diff --git a/src/kitemviews/kfileitemlistview.cpp b/src/kitemviews/kfileitemlistview.cpp index 2e3744cea..3a02d537d 100644 --- a/src/kitemviews/kfileitemlistview.cpp +++ b/src/kitemviews/kfileitemlistview.cpp @@ -105,18 +105,6 @@ QStringList KFileItemListView::enabledPlugins() const return m_modelRolesUpdater ? m_modelRolesUpdater->enabledPlugins() : QStringList(); } -void KFileItemListView::setLocalFileSizePreviewLimit(const qlonglong size) -{ - if (m_modelRolesUpdater) { - m_modelRolesUpdater->setLocalFileSizePreviewLimit(size); - } -} - -qlonglong KFileItemListView::localFileSizePreviewLimit() const -{ - return m_modelRolesUpdater ? m_modelRolesUpdater->localFileSizePreviewLimit() : 0; -} - QPixmap KFileItemListView::createDragPixmap(const KItemSet &indexes) const { if (!model()) { diff --git a/src/kitemviews/kfileitemlistview.h b/src/kitemviews/kfileitemlistview.h index d6ffd3d0f..eae00f1f0 100644 --- a/src/kitemviews/kfileitemlistview.h +++ b/src/kitemviews/kfileitemlistview.h @@ -60,17 +60,6 @@ public: */ QStringList enabledPlugins() const; - /** - * Sets the maximum file size of local files for which - * previews will be generated (if enabled). A value of 0 - * indicates no file size limit. - * Per default the value from KConfigGroup "PreviewSettings" - * MaximumSize is used, 0 otherwise. - * @param size - */ - void setLocalFileSizePreviewLimit(qlonglong size); - qlonglong localFileSizePreviewLimit() const; - QPixmap createDragPixmap(const KItemSet &indexes) const override; /** diff --git a/src/kitemviews/kfileitemmodelrolesupdater.cpp b/src/kitemviews/kfileitemmodelrolesupdater.cpp index 5e68b29e3..cff4c6f2e 100644 --- a/src/kitemviews/kfileitemmodelrolesupdater.cpp +++ b/src/kitemviews/kfileitemmodelrolesupdater.cpp @@ -76,7 +76,6 @@ KFileItemModelRolesUpdater::KFileItemModelRolesUpdater(KFileItemModel *model, QO , m_roles() , m_resolvableRoles() , m_enabledPlugins() - , m_localFileSizePreviewLimit(0) , m_pendingSortRoleItems() , m_pendingIndexes() , m_pendingPreviewItems() @@ -97,7 +96,6 @@ KFileItemModelRolesUpdater::KFileItemModelRolesUpdater(KFileItemModel *model, QO const KConfigGroup globalConfig(KSharedConfig::openConfig(), QStringLiteral("PreviewSettings")); m_enabledPlugins = globalConfig.readEntry("Plugins", KIO::PreviewJob::defaultPlugins()); - m_localFileSizePreviewLimit = static_cast<qulonglong>(globalConfig.readEntry("MaximumSize", 0)); connect(m_model, &KFileItemModel::itemsInserted, this, &KFileItemModelRolesUpdater::slotItemsInserted); connect(m_model, &KFileItemModel::itemsRemoved, this, &KFileItemModelRolesUpdater::slotItemsRemoved); @@ -333,16 +331,6 @@ QStringList KFileItemModelRolesUpdater::enabledPlugins() const return m_enabledPlugins; } -void KFileItemModelRolesUpdater::setLocalFileSizePreviewLimit(const qlonglong size) -{ - m_localFileSizePreviewLimit = size; -} - -qlonglong KFileItemModelRolesUpdater::localFileSizePreviewLimit() const -{ - return m_localFileSizePreviewLimit; -} - void KFileItemModelRolesUpdater::setHoverSequenceState(const QUrl &itemUrl, int seqIdx) { const KFileItem item = m_model->fileItem(itemUrl); @@ -985,7 +973,6 @@ void KFileItemModelRolesUpdater::startPreviewJob() KIO::PreviewJob *job = new KIO::PreviewJob(items, cacheSize(), &m_enabledPlugins); job->setDevicePixelRatio(m_devicePixelRatio); - job->setIgnoreMaximumSize(referenceItem.isLocalFile() && !referenceItem.isSlow() && m_localFileSizePreviewLimit <= 0); if (job->uiDelegate()) { KJobWidgets::setWindow(job, qApp->activeWindow()); } @@ -1094,7 +1081,6 @@ void KFileItemModelRolesUpdater::loadNextHoverSequencePreview() KIO::PreviewJob *job = new KIO::PreviewJob({m_hoverSequenceItem}, cacheSize(), &m_enabledPlugins); job->setSequenceIndex(loadSeqIdx); - job->setIgnoreMaximumSize(m_hoverSequenceItem.isLocalFile() && !m_hoverSequenceItem.isSlow() && m_localFileSizePreviewLimit <= 0); if (job->uiDelegate()) { KJobWidgets::setWindow(job, qApp->activeWindow()); } diff --git a/src/kitemviews/kfileitemmodelrolesupdater.h b/src/kitemviews/kfileitemmodelrolesupdater.h index ec56d9801..fc6e78295 100644 --- a/src/kitemviews/kfileitemmodelrolesupdater.h +++ b/src/kitemviews/kfileitemmodelrolesupdater.h @@ -148,17 +148,6 @@ public: QStringList enabledPlugins() const; /** - * Sets the maximum file size of local files for which - * previews will be generated (if enabled). A value of 0 - * indicates no file size limit. - * Per default the value from KConfigGroup "PreviewSettings" - * MaximumSize is used, 0 otherwise. - * @param size - */ - void setLocalFileSizePreviewLimit(qlonglong size); - qlonglong localFileSizePreviewLimit() const; - - /** * If set to true, directories contents are scanned to determine their size * Default true */ @@ -385,7 +374,6 @@ private: QSet<QByteArray> m_roles; QSet<QByteArray> m_resolvableRoles; QStringList m_enabledPlugins; - qulonglong m_localFileSizePreviewLimit; // Items for which the sort role still has to be determined. QSet<KFileItem> m_pendingSortRoleItems; diff --git a/src/views/dolphinitemlistview.cpp b/src/views/dolphinitemlistview.cpp index 1aa0df736..f9e710a31 100644 --- a/src/views/dolphinitemlistview.cpp +++ b/src/views/dolphinitemlistview.cpp @@ -101,7 +101,6 @@ void DolphinItemListView::readSettings() const KConfigGroup globalConfig(KSharedConfig::openConfig(), QStringLiteral("PreviewSettings")); setEnabledPlugins(globalConfig.readEntry("Plugins", KIO::PreviewJob::defaultPlugins())); - setLocalFileSizePreviewLimit(globalConfig.readEntry("MaximumSize", 0)); endTransaction(); } |
