We were calling methods within loadSettings() which should have been moved to inside the constructor instead. Examples include setting up a slider's notch-type(bottom or top). Especially significant since loadSettings() gets called more often than the constructor.

svn path=/trunk/KDE/kdebase/apps/; revision=920419

1 files changed, 5 insertions, 6 deletions

diff --git a/src/settings/previewssettingspage.cpp b/src/settings/previewssettingspage.cpp
index d9a361c8d..524ff487d 100644
--- a/src/settings/previewssettingspage.cpp
+++ b/src/settings/previewssettingspage.cpp
@@ -54,8 +54,13 @@ PreviewsSettingsPage::PreviewsSettingsPage(QWidget* parent) :
 
     new QLabel(i18nc("@label:slider", "Maximum file size:"), hBox);
     m_maxPreviewSize = new QSlider(Qt::Horizontal, hBox);
+    m_maxPreviewSize->setPageStep(10);
+    m_maxPreviewSize->setSingleStep(1);
+    m_maxPreviewSize->setTickPosition(QSlider::TicksBelow);
 
     m_spinBox = new QSpinBox(hBox);
+    m_spinBox->setSingleStep(1);
+    m_spinBox->setSuffix(" MB");
 
     connect(m_maxPreviewSize, SIGNAL(valueChanged(int)),
             m_spinBox, SLOT(setValue(int)));
@@ -109,9 +114,6 @@ void PreviewsSettingsPage::loadSettings()
     const int min = 1;   // MB
     const int max = 100; // MB
     m_maxPreviewSize->setRange(min, max);
-    m_maxPreviewSize->setPageStep(10);
-    m_maxPreviewSize->setSingleStep(1);
-    m_maxPreviewSize->setTickPosition(QSlider::TicksBelow);
 
     KConfigGroup globalConfig(KGlobal::config(), "PreviewSettings");
     // TODO: The default value of 5 MB must match with the default value inside
@@ -124,10 +126,7 @@ void PreviewsSettingsPage::loadSettings()
     } else if (maxMByteSize > max) {
         maxMByteSize = max;
     }
-
     m_spinBox->setRange(min, max);
-    m_spinBox->setSingleStep(1);
-    m_spinBox->setSuffix(" MB");
 
     m_maxPreviewSize->setValue(maxMByteSize);
     m_spinBox->setValue(m_maxPreviewSize->value());