diff options
| author | Felix Ernst <[email protected]> | 2020-08-12 20:45:17 +0200 |
|---|---|---|
| committer | Elvis Angelaccio <[email protected]> | 2020-11-09 23:49:07 +0100 |
| commit | b6fc58c3c32b03f504a5f697b62c4834dc3f650a (patch) | |
| tree | cda0394689ba6001bc14b1895c2ef95a4baf2dcd /src/dolphinbookmarkhandler.cpp | |
| parent | 00abc6d28031569de17e4888d8b21e6afbe0872f (diff) | |
Adress the first round of Angelaccio's review comments
- Split the viewContainers(bool includeInActive) into two methods
without parameters
- Prevent users from accidently hiding all Url Navigators by
preventing the dangerous action and then displaying a helpful
message instead
Unrelated to review comments: Remove a useless line of code
Diffstat (limited to 'src/dolphinbookmarkhandler.cpp')
| -rw-r--r-- | src/dolphinbookmarkhandler.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/dolphinbookmarkhandler.cpp b/src/dolphinbookmarkhandler.cpp index efcb41692..576a9314b 100644 --- a/src/dolphinbookmarkhandler.cpp +++ b/src/dolphinbookmarkhandler.cpp @@ -68,7 +68,7 @@ bool DolphinBookmarkHandler::supportsTabs() const QList<KBookmarkOwner::FutureBookmark> DolphinBookmarkHandler::currentBookmarkList() const { - const auto viewContainers = m_mainWindow->viewContainers(false); + const auto viewContainers = m_mainWindow->activeViewContainers(); QList<FutureBookmark> bookmarks; bookmarks.reserve(viewContainers.size()); for (const auto viewContainer : viewContainers) { |