┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/dolphinnavigatorswidgetaction.cpp
diff options
context:
space:
mode:
authorFelix Ernst <[email protected]>2021-02-08 21:32:10 +0000
committerElvis Angelaccio <[email protected]>2021-02-08 21:32:10 +0000
commita825e1bd74246dc97dde3f48b1d9ead7a214b744 (patch)
tree57158cf021f5db25b1f3740ec7db870569d2f622 /src/dolphinnavigatorswidgetaction.cpp
parent7eae6bba5f2c9dbd9e40e1194e8455e9e4ed3f6d (diff)
Avoid KJob::exec() in DolphinView
This commit replaces an error-prone usage of KIO::StatJob::exec() in DolphinView with the recommended KIO::StatJob::start(). The containing method DolphinView::statusBarText() is changed to be a method without return value: requestStatusBarText() The new status bar text is instead returned through a new setStatusBarText() signal that will be emitted asynchronously if necessary. The calling code that deals with status bar text is refactored to correctly work despite the new asynchronicity. The helper method calculateItemCount() is moved into requestStatusBarText() and some other code from requestStatusBarText() is moved into a new helper method emitStatusBarText(). The documentation of KIO::KJob::exec() explains why it should be avoided. A reproducible crash is the reason for this commit.
Diffstat (limited to 'src/dolphinnavigatorswidgetaction.cpp')
0 files changed, 0 insertions, 0 deletions