diff options
| author | David Hallas <[email protected]> | 2018-07-18 23:20:18 +0200 |
|---|---|---|
| committer | Elvis Angelaccio <[email protected]> | 2018-07-18 23:20:19 +0200 |
| commit | 4536e25ac929d8d37ffbbba0642de662bcc9f891 (patch) | |
| tree | 93d852e488e6c5f7f522a263021204b28318d677 /src/dolphintabbar.cpp | |
| parent | 43ab5bdc5f8b709bc278611a5f6924d6b0aaf1cd (diff) | |
Fixes memory leak in KItemListViewAccessible
Summary: The KItemListViewAccessible class has a list of QAccessibleInterface pointers in a member variable m_cells. The problem is that when new entries are created, the newly allocated pointer is not stored in the list, only a nullptr is store, this renders the cleanup code in the destructor useless. This patch simply stores the pointer in the list, causing the destructor to correctly free the memory.
Test Plan: I found this issue using address sanitizer. Simply building Dolphin with -fsanitize=address and opening a window caused the memory leak.
Reviewers: #dolphin, jtamate, elvisangelaccio
Reviewed By: #dolphin, jtamate, elvisangelaccio
Subscribers: elvisangelaccio, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D14168
Diffstat (limited to 'src/dolphintabbar.cpp')
0 files changed, 0 insertions, 0 deletions