DolphinTabWidget: cleanup index-by-URL API usage

Summary:
Follow-up of D23655 where we didn't have time to polish the code:

- add a couple of variables to make the code more clear.
- remove the `get` prefix which we usually don't use in Qt code.
- make the function private since it's very tied to implementation.
- add a new isUrlOpen public method as wrapper.

Reviewers: feverfew

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D23860

1 files changed, 13 insertions, 7 deletions

diff --git a/src/dolphintabwidget.h b/src/dolphintabwidget.h
index 7eb001b21..4351a40a8 100644
--- a/src/dolphintabwidget.h
+++ b/src/dolphintabwidget.h
@@ -79,14 +79,10 @@ public:
     void refreshViews();
 
     /**
-     * @param url The URL that we would like
-     * @return a QPair with first containing the index of the tab with the
-     * desired URL or -1 if not found. Second says true if URL is in primary
-     * view container, false otherwise. False means the URL is in the secondary
-     * view container, unless first == -1. In that case the value of second
-     * is meaningless.
+     * @return Whether any of the tab pages contains @p url in their primary
+     * or secondary view.
      */
-    QPair<int, bool> getIndexByUrl(const QUrl& url) const;
+    bool isUrlOpen(const QUrl& url) const;
 
 signals:
     /**
@@ -221,6 +217,16 @@ private:
      */
     QString tabName(DolphinTabPage* tabPage) const;
 
+    /**
+     * @param url The URL that we would like
+     * @return a QPair with first containing the index of the tab with the
+     * desired URL or -1 if not found. Second says true if URL is in primary
+     * view container, false otherwise. False means the URL is in the secondary
+     * view container, unless first == -1. In that case the value of second
+     * is meaningless.
+     */
+    QPair<int, bool> indexByUrl(const QUrl& url) const;
+
 private:
     /** Caches the (negated) places panel visibility */
     bool m_placesSelectorVisible;