diff options
| author | Ismael Asensio <[email protected]> | 2019-09-01 21:59:43 +0200 |
|---|---|---|
| committer | Elvis Angelaccio <[email protected]> | 2019-09-01 21:59:43 +0200 |
| commit | 3a7586907ed834fb3c09d47e047da305a25374a2 (patch) | |
| tree | 9b49c59975b6541ef9c3481609d7ffefb4753b65 /src/dolphinui.rc | |
| parent | 7f6d49377b3b66da9811d94aa0166872e4f44836 (diff) | |
[dolphin] Add an action to toggle the searchbar
Summary:
Make search action toggle the searchbar instead of just launching it.
The search action in dolphin did only bring up the search bar, but to close it again you had to go to the closing button on the same searchbar.
This behavior in inconsistent with other dolphin actions which toggle panels or tools.
BEFORE:
{F7256652}
AFTER:
{F7256862}
BUG: 344617
FIXED-IN: 19.12.0
Closes T8473
Depends on D23075
Test Plan:
- Enable the search mode: the searchbar appears and the toolbar button gets checked
- Press the search button again, and it goes back to normal mode.
- The search button state is coherent with the searchbox
- Coherence is kept when changing to a split view or different tab
- Shorcut <Ctrl-F> does not close the searchbar, but moves the focus to it.
Reviewers: #dolphin, ngraham, #vdg, elvisangelaccio
Reviewed By: ngraham, #vdg
Subscribers: ndavis, felixernst, elvisangelaccio, kfm-devel
Tags: #dolphin
Maniphest Tasks: T8473
Differential Revision: https://phabricator.kde.org/D23232
Diffstat (limited to 'src/dolphinui.rc')
| -rw-r--r-- | src/dolphinui.rc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/dolphinui.rc b/src/dolphinui.rc index 207c5d4c2..69663c471 100644 --- a/src/dolphinui.rc +++ b/src/dolphinui.rc @@ -1,5 +1,5 @@ <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd"> -<kpartgui name="dolphin" version="23"> +<kpartgui name="dolphin" version="24"> <MenuBar> <Menu name="file"> <Action name="new_menu" /> @@ -102,7 +102,7 @@ <Spacer name="spacer_0" /> <Action name="split_view" /> <Action name="split_stash" /> - <Action name="edit_find" /> + <Action name="toggle_search" /> </ToolBar> <ActionProperties scheme="Default"> <Action priority="0" name="go_back"/> @@ -118,6 +118,6 @@ <Action priority="0" name="edit_cut"/> <Action priority="0" name="edit_copy"/> <Action priority="0" name="edit_paste"/> - <Action priority="0" name="edit_find"/> + <Action priority="0" name="toggle_search"/> </ActionProperties> </kpartgui> |
