diff options
| author | Jaime Torres <[email protected]> | 2018-07-13 18:54:49 +0200 |
|---|---|---|
| committer | Jaime Torres <[email protected]> | 2018-07-13 18:55:42 +0200 |
| commit | 765cc968c9dfbd4350226b775377506135c0442d (patch) | |
| tree | 0639585929650f3bd1204d001813cf54444290fb /src/kitemviews/kfileitemmodel.h | |
| parent | 1ba972adf57aa82561eeea95890914d4843fc725 (diff) | |
Speedup sort
Summary:
Use a lambda function to use only one QCollator initialized only once.
This requires a workaround for https://bugreports.qt.io/browse/QTBUG-69361
Just a single comparison to force the clean state of QCollator.
Test Plan:
Sorting in a directory with 82874 images:
[TIME] Sorting: 19883 (before)
[TIME] Sorting: 4198 (after)
kfileitemmodelbenchmark before: .............. Passed 29.36 sec
kfileitemmodelbenchmark after: .............. Passed 20.39 sec
Reviewers: #dolphin, #frameworks, markg, elvisangelaccio, bruns
Reviewed By: #dolphin, markg, elvisangelaccio
Subscribers: elvisangelaccio, apol, bruns, markg, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D13814
Diffstat (limited to 'src/kitemviews/kfileitemmodel.h')
| -rw-r--r-- | src/kitemviews/kfileitemmodel.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/kitemviews/kfileitemmodel.h b/src/kitemviews/kfileitemmodel.h index 134c50245..a931a28cc 100644 --- a/src/kitemviews/kfileitemmodel.h +++ b/src/kitemviews/kfileitemmodel.h @@ -499,7 +499,6 @@ private: // and done step after step in slotCompleted(). QSet<QUrl> m_urlsToExpand; - friend class KFileItemModelLessThan; // Accesses lessThan() method friend class KFileItemModelRolesUpdater; // Accesses emitSortProgress() method friend class KFileItemModelTest; // For unit testing friend class KFileItemModelBenchmark; // For unit testing |