diff options
| author | David Hallas <[email protected]> | 2018-07-29 12:10:16 +0200 |
|---|---|---|
| committer | David Hallas <[email protected]> | 2019-02-24 18:22:55 +0100 |
| commit | d2783df3104dfc4575d3e8fc9077e3b21fd944c8 (patch) | |
| tree | 1ea358bede88826aa04ffea67f1e3d78b2fbe292 /src/kitemviews/kitemlistheader.cpp | |
| parent | 16edd9ccec5ad830d8a7058c5971c8a23c0388c4 (diff) | |
Fixes memory leak of KItemListHeader
Summary:
Fixes memory leak of KItemListHeader
The KItemListHeader passed the listView parent object to the QObject
base class, but that pointer seems to always be nullptr causing the
KItemListHeader to not be memory managed by anything. Instead simple
use the listView as parent pointer.
Test Plan: This leak was found using Address Sanitizer
Reviewers: elvisangelaccio
Reviewed By: elvisangelaccio
Subscribers: elvisangelaccio, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D14453
Diffstat (limited to 'src/kitemviews/kitemlistheader.cpp')
| -rw-r--r-- | src/kitemviews/kitemlistheader.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/kitemviews/kitemlistheader.cpp b/src/kitemviews/kitemlistheader.cpp index cfc2c2b72..a82af44e7 100644 --- a/src/kitemviews/kitemlistheader.cpp +++ b/src/kitemviews/kitemlistheader.cpp @@ -74,7 +74,7 @@ qreal KItemListHeader::preferredColumnWidth(const QByteArray& role) const } KItemListHeader::KItemListHeader(KItemListView* listView) : - QObject(listView->parent()), + QObject(listView), m_view(listView) { m_headerWidget = m_view->m_headerWidget; |