diff options
| author | Kai Uwe Broulik <[email protected]> | 2018-03-29 09:21:17 +0200 |
|---|---|---|
| committer | Kai Uwe Broulik <[email protected]> | 2018-03-29 09:21:17 +0200 |
| commit | 40f9cfd519a3244929190146a3215ae12b98270b (patch) | |
| tree | b7c7e06c515db296312650b515af83320e0f29b7 /src/kitemviews/kitemlistwidget.cpp | |
| parent | 49e0315584e8fca507cb4fb397bfd5e46e67c164 (diff) | |
[KItemListView] Check if KItemListStyleOption actually changed before emitting a change
This avoids work being done when it doesn't need to be.
For instance, the preview generator waits for everything to have settled using a 200ms timer before generating a preview.
This timer fired also in response to onStyleOptionChanged and needlessly delayed preview generation when navigating between folders
despite the style option (e.g. icon size, view mode) not having changed.
Differential Revision: https://phabricator.kde.org/D11481
Diffstat (limited to 'src/kitemviews/kitemlistwidget.cpp')
| -rw-r--r-- | src/kitemviews/kitemlistwidget.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/kitemviews/kitemlistwidget.cpp b/src/kitemviews/kitemlistwidget.cpp index 61dd7256e..28b374620 100644 --- a/src/kitemviews/kitemlistwidget.cpp +++ b/src/kitemviews/kitemlistwidget.cpp @@ -191,10 +191,13 @@ qreal KItemListWidget::columnWidth(const QByteArray& role) const void KItemListWidget::setStyleOption(const KItemListStyleOption& option) { + if (m_styleOption == option) { + return; + } + const KItemListStyleOption previous = m_styleOption; clearHoverCache(); m_styleOption = option; - styleOptionChanged(option, previous); update(); } |
