diff options
| author | Frank Reininghaus <[email protected]> | 2013-08-14 23:57:51 +0200 |
|---|---|---|
| committer | Frank Reininghaus <[email protected]> | 2013-08-14 23:57:51 +0200 |
| commit | 59723fca41a44e4d1ee753e93589027cbdf8d20d (patch) | |
| tree | d72e2fd446eb90621c1249b8ee687b00bcd63972 /src/kitemviews/kstandarditemlistwidget.cpp | |
| parent | fd5ba3b4b22e923cff11b65654e9b6f931ce9a3c (diff) | |
Do not store default values in QHash<QByteArray, QVariant>
Storing values which are equivalent to default-constructed QVariants
does not make much sense because QHash::value returns the same value
even if the corresponding key is not found in the hash.
This commit reduces Dolphin's memory consumption in large folders by
up to 7.3% (tested a folder with 100,000 files in Details View) and
reduces the time required for loading a folder.
BUG: 323517
FIXED-IN: 4.11.1
REVIEW: 111922
Diffstat (limited to 'src/kitemviews/kstandarditemlistwidget.cpp')
| -rw-r--r-- | src/kitemviews/kstandarditemlistwidget.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/kitemviews/kstandarditemlistwidget.cpp b/src/kitemviews/kstandarditemlistwidget.cpp index 621cd81cc..2a89004c6 100644 --- a/src/kitemviews/kstandarditemlistwidget.cpp +++ b/src/kitemviews/kstandarditemlistwidget.cpp @@ -791,7 +791,6 @@ void KStandardItemListWidget::updateExpansionArea() { if (m_supportsItemExpanding) { const QHash<QByteArray, QVariant> values = data(); - Q_ASSERT(values.contains("expandedParentsCount")); const int expandedParentsCount = values.value("expandedParentsCount", 0).toInt(); if (expandedParentsCount >= 0) { const qreal widgetHeight = size().height(); |
