┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/kitemviews/kstandarditemlistwidget.h
diff options
context:
space:
mode:
authorAndreas Krutzler <[email protected]>2017-11-18 20:32:37 -0700
committerElvis Angelaccio <[email protected]>2017-11-19 11:17:29 +0100
commitaf27d5735c77c825799c570151a85a230a91e8ed (patch)
tree1f5484b8c0a517615b25d761caf555d5fc4cb899 /src/kitemviews/kstandarditemlistwidget.h
parenteab64f97326f43367eb859b75db384fa9b76df87 (diff)
Fix scrolling during inline renaming causes rename of wrong file
Summary: Scrolling during inline renaming accepts the renaming now, like if one would hit Return for example. I chose this approach because it seems the easiest way to fix this. This also fixes the “possible” Ui glitch where the renaming KTextField doesn’t move along with the list item. Possible glitch, because I don’t know if this is intentional, but for me it looks broken. BUG: 378786 Fixes T7443 Test Plan: * Enable "Rename inline" in dolphin settings * Go to a folder where you have to scroll through items (many files, big zoom,…) * Start to rename a file (context menu, F2, …) * Scroll with mouse wheel * Rename accepted -> file is renamed Reviewers: ngraham, rkflx, #dolphin, elvisangelaccio Reviewed By: ngraham, rkflx, #dolphin, elvisangelaccio Subscribers: anthonyfieroni, elvisangelaccio, #dolphin Maniphest Tasks: T7443 Differential Revision: https://phabricator.kde.org/D8822
Diffstat (limited to 'src/kitemviews/kstandarditemlistwidget.h')
-rw-r--r--src/kitemviews/kstandarditemlistwidget.h3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/kitemviews/kstandarditemlistwidget.h b/src/kitemviews/kstandarditemlistwidget.h
index e6ba4bb3f..cb7364795 100644
--- a/src/kitemviews/kstandarditemlistwidget.h
+++ b/src/kitemviews/kstandarditemlistwidget.h
@@ -185,6 +185,9 @@ protected:
virtual void hideEvent(QHideEvent* event) Q_DECL_OVERRIDE;
bool event(QEvent *event) Q_DECL_OVERRIDE;
+public slots:
+ void finishRoleEditing();
+
private slots:
void slotCutItemsChanged();
void slotRoleEditingCanceled(const QByteArray& role, const QVariant& value);