Make sure that KItemListSizeHintResolver is always consistent

This was the root cause of bug 317827. The assert tried to make sure
that we never access KItemListSizeHintResolver from
KItemListViewLayouter inside the loop over the item ranges. This would
be dangerous because it might be in an inconsistent state - the removed
item ranges were removed step by step, so accessing the item size hints
before the operation was finished could lead to wrong results.

The solution is to insert/remove all item ranges immediately. A nice
side effect is that there are no sources of O(N^2) complexity in
KItemListSizeHintResolver any more if many item ranges are
inserted/removed.

BUG: 317827
FIXED-IN: 4.11.0
REVIEW: 111382

1 files changed, 3 insertions, 3 deletions

diff --git a/src/kitemviews/private/kitemlistsizehintresolver.h b/src/kitemviews/private/kitemlistsizehintresolver.h
index 6f50d673c..5ec5f4a21 100644
--- a/src/kitemviews/private/kitemlistsizehintresolver.h
+++ b/src/kitemviews/private/kitemlistsizehintresolver.h
@@ -22,7 +22,7 @@
 
 #include <libdolphin_export.h>
 
-#include <QByteArray>
+#include <kitemviews/kitemmodelbase.h>
 #include <QSizeF>
 #include <QVector>
 
@@ -38,8 +38,8 @@ public:
     virtual ~KItemListSizeHintResolver();
     QSizeF sizeHint(int index) const;
 
-    void itemsInserted(int index, int count);
-    void itemsRemoved(int index, int count);
+    void itemsInserted(const KItemRangeList& itemRanges);
+    void itemsRemoved(const KItemRangeList& itemRanges);
     void itemsMoved(int index, int count);
     void itemsChanged(int index, int count, const QSet<QByteArray>& roles);