diff options
| author | Friedrich W. H. Kossebau <[email protected]> | 2023-07-04 22:07:48 +0200 |
|---|---|---|
| committer | Méven Car <[email protected]> | 2023-07-05 07:59:18 +0000 |
| commit | ed2d352c42a6d517d4f29b3582c0e00aa34fe647 (patch) | |
| tree | d1b487efb15e1d1a6b9ad8c07c3fe2a01f19a505 /src/kitemviews | |
| parent | 7fcf4e084debda4bddc82de563fbacdabc6a87ef (diff) | |
Add explicit moc includes to sources for moc-covered headers
* speeds up incremental builds as changes to a header will not always
need the full mocs_compilation.cpp for all the target's headers rebuild,
while having a moc file sourced into a source file only adds minor
extra costs, due to small own code and the used headers usually
already covered by the source file, being for the same class/struct
* seems to not slow down clean builds, due to empty mocs_compilation.cpp
resulting in those quickly processed, while the minor extra cost of the
sourced moc files does not outweigh that in summary.
Measured times actually improved by some percent points.
(ideally CMake would just skip empty mocs_compilation.cpp & its object
file one day)
* enables compiler to see all methods of a class in same compilation unit
to do some sanity checks
* potentially more inlining in general, due to more in the compilation unit
* allows to keep using more forward declarations in the header, as with the
moc code being sourced into the cpp file there definitions can be ensured
and often are already for the needs of the normal class methods
Diffstat (limited to 'src/kitemviews')
26 files changed, 51 insertions, 0 deletions
diff --git a/src/kitemviews/kfileitemlistview.cpp b/src/kitemviews/kfileitemlistview.cpp index 668ebdfb2..2ff5c9fb9 100644 --- a/src/kitemviews/kfileitemlistview.cpp +++ b/src/kitemviews/kfileitemlistview.cpp @@ -442,3 +442,5 @@ QSize KFileItemListView::availableIconSize() const return QSize(iconSize, iconSize); } + +#include "moc_kfileitemlistview.cpp" diff --git a/src/kitemviews/kfileitemlistwidget.cpp b/src/kitemviews/kfileitemlistwidget.cpp index 385067af0..771403b70 100644 --- a/src/kitemviews/kfileitemlistwidget.cpp +++ b/src/kitemviews/kfileitemlistwidget.cpp @@ -235,3 +235,5 @@ KFileItemListView *KFileItemListWidget::listView() { return dynamic_cast<KFileItemListView *>(parentItem()); } + +#include "moc_kfileitemlistwidget.cpp" diff --git a/src/kitemviews/kfileitemmodel.cpp b/src/kitemviews/kfileitemmodel.cpp index 629332703..bbe725dfd 100644 --- a/src/kitemviews/kfileitemmodel.cpp +++ b/src/kitemviews/kfileitemmodel.cpp @@ -2863,3 +2863,5 @@ void KFileItemModel::slotListerError(KIO::Job *job) Q_EMIT errorMessage(!errorString.isEmpty() ? errorString : i18nc("@info:status", "Unknown error.")); } } + +#include "moc_kfileitemmodel.cpp" diff --git a/src/kitemviews/kfileitemmodelrolesupdater.cpp b/src/kitemviews/kfileitemmodelrolesupdater.cpp index 9d8ae55da..bd4bd7e51 100644 --- a/src/kitemviews/kfileitemmodelrolesupdater.cpp +++ b/src/kitemviews/kfileitemmodelrolesupdater.cpp @@ -1495,3 +1495,5 @@ void KFileItemModelRolesUpdater::trimHoverSequenceLoadedItems() } } } + +#include "moc_kfileitemmodelrolesupdater.cpp" diff --git a/src/kitemviews/kitemlistcontainer.cpp b/src/kitemviews/kitemlistcontainer.cpp index 1d62c9620..3893ceaea 100644 --- a/src/kitemviews/kitemlistcontainer.cpp +++ b/src/kitemviews/kitemlistcontainer.cpp @@ -396,3 +396,4 @@ void KItemListContainer::updateScrollOffsetScrollBarPolicy() } #include "kitemlistcontainer.moc" +#include "moc_kitemlistcontainer.cpp" diff --git a/src/kitemviews/kitemlistcontroller.cpp b/src/kitemviews/kitemlistcontroller.cpp index 74a631d8d..5598e77bd 100644 --- a/src/kitemviews/kitemlistcontroller.cpp +++ b/src/kitemviews/kitemlistcontroller.cpp @@ -1831,3 +1831,5 @@ void KItemListController::slotStateChanged(QScroller::State newState) m_scrollerIsScrolling = false; } } + +#include "moc_kitemlistcontroller.cpp" diff --git a/src/kitemviews/kitemlistgroupheader.cpp b/src/kitemviews/kitemlistgroupheader.cpp index 66cd74eb4..0604f2da0 100644 --- a/src/kitemviews/kitemlistgroupheader.cpp +++ b/src/kitemviews/kitemlistgroupheader.cpp @@ -226,3 +226,5 @@ QColor KItemListGroupHeader::baseColor() const const QPalette::ColorGroup group = isActiveWindow() ? QPalette::Active : QPalette::Inactive; return styleOption().palette.color(group, normalBaseColorRole()); } + +#include "moc_kitemlistgroupheader.cpp" diff --git a/src/kitemviews/kitemlistheader.cpp b/src/kitemviews/kitemlistheader.cpp index dfbe7ab2c..bb3153794 100644 --- a/src/kitemviews/kitemlistheader.cpp +++ b/src/kitemviews/kitemlistheader.cpp @@ -88,3 +88,5 @@ KItemListHeader::KItemListHeader(KItemListView *listView) connect(m_headerWidget, &KItemListHeaderWidget::columnWidthChangeFinished, this, &KItemListHeader::columnWidthChangeFinished); connect(m_headerWidget, &KItemListHeaderWidget::sidePaddingChanged, this, &KItemListHeader::sidePaddingChanged); } + +#include "moc_kitemlistheader.cpp" diff --git a/src/kitemviews/kitemlistselectionmanager.cpp b/src/kitemviews/kitemlistselectionmanager.cpp index 2a2fbac81..6f7f0e077 100644 --- a/src/kitemviews/kitemlistselectionmanager.cpp +++ b/src/kitemviews/kitemlistselectionmanager.cpp @@ -395,3 +395,5 @@ int KItemListSelectionManager::indexAfterRangesRemoving(int index, const KItemRa } return qBound(-1, index - dec, m_model->count() - 1); } + +#include "moc_kitemlistselectionmanager.cpp" diff --git a/src/kitemviews/kitemlistview.cpp b/src/kitemviews/kitemlistview.cpp index 7f1347920..7a3cbbcb6 100644 --- a/src/kitemviews/kitemlistview.cpp +++ b/src/kitemviews/kitemlistview.cpp @@ -2769,3 +2769,5 @@ void KItemListGroupHeaderCreatorBase::recycle(KItemListGroupHeader *header) header->setOpacity(1.0); pushRecycleableWidget(header); } + +#include "moc_kitemlistview.cpp" diff --git a/src/kitemviews/kitemlistwidget.cpp b/src/kitemviews/kitemlistwidget.cpp index 2c8ef70a5..c8b3d2c3c 100644 --- a/src/kitemviews/kitemlistwidget.cpp +++ b/src/kitemviews/kitemlistwidget.cpp @@ -604,3 +604,5 @@ void KItemListWidget::drawItemStyleOption(QPainter *painter, QWidget *widget, QS viewItemOption.rect = selectionRect().toRect(); style()->drawPrimitive(QStyle::PE_PanelItemViewItem, &viewItemOption, painter, widget); } + +#include "moc_kitemlistwidget.cpp" diff --git a/src/kitemviews/kitemmodelbase.cpp b/src/kitemviews/kitemmodelbase.cpp index e302d6093..566caefaa 100644 --- a/src/kitemviews/kitemmodelbase.cpp +++ b/src/kitemviews/kitemmodelbase.cpp @@ -165,3 +165,5 @@ QUrl KItemModelBase::directory() const { return QUrl(); } + +#include "moc_kitemmodelbase.cpp" diff --git a/src/kitemviews/kstandarditemlistgroupheader.cpp b/src/kitemviews/kstandarditemlistgroupheader.cpp index e8468dacc..00b255a9d 100644 --- a/src/kitemviews/kstandarditemlistgroupheader.cpp +++ b/src/kitemviews/kstandarditemlistgroupheader.cpp @@ -109,3 +109,5 @@ void KStandardItemListGroupHeader::updateCache() m_text = text; } } + +#include "moc_kstandarditemlistgroupheader.cpp" diff --git a/src/kitemviews/kstandarditemlistview.cpp b/src/kitemviews/kstandarditemlistview.cpp index f94aed0b5..a4e7c3edd 100644 --- a/src/kitemviews/kstandarditemlistview.cpp +++ b/src/kitemviews/kstandarditemlistview.cpp @@ -179,3 +179,5 @@ void KStandardItemListView::updateLayoutOfVisibleItems() } } } + +#include "moc_kstandarditemlistview.cpp" diff --git a/src/kitemviews/kstandarditemlistwidget.cpp b/src/kitemviews/kstandarditemlistwidget.cpp index afe614363..c4eab6d74 100644 --- a/src/kitemviews/kstandarditemlistwidget.cpp +++ b/src/kitemviews/kstandarditemlistwidget.cpp @@ -1610,3 +1610,5 @@ qreal KStandardItemListWidget::columnPadding(const KItemListStyleOption &option) { return option.padding * 6; } + +#include "moc_kstandarditemlistwidget.cpp" diff --git a/src/kitemviews/private/kdirectorycontentscounter.cpp b/src/kitemviews/private/kdirectorycontentscounter.cpp index 648b20b6f..47f538447 100644 --- a/src/kitemviews/private/kdirectorycontentscounter.cpp +++ b/src/kitemviews/private/kdirectorycontentscounter.cpp @@ -292,3 +292,5 @@ void KDirectoryContentsCounter::stopWorker() } m_currentPath.clear(); } + +#include "moc_kdirectorycontentscounter.cpp" diff --git a/src/kitemviews/private/kdirectorycontentscounterworker.cpp b/src/kitemviews/private/kdirectorycontentscounterworker.cpp index eb456da25..2d60091c6 100644 --- a/src/kitemviews/private/kdirectorycontentscounterworker.cpp +++ b/src/kitemviews/private/kdirectorycontentscounterworker.cpp @@ -156,3 +156,5 @@ void KDirectoryContentsCounterWorker::countDirectoryContents(const QString &path m_stopping = false; Q_EMIT finished(); } + +#include "moc_kdirectorycontentscounterworker.cpp" diff --git a/src/kitemviews/private/kfileitemclipboard.cpp b/src/kitemviews/private/kfileitemclipboard.cpp index 33bf298ed..47718fa02 100644 --- a/src/kitemviews/private/kfileitemclipboard.cpp +++ b/src/kitemviews/private/kfileitemclipboard.cpp @@ -68,3 +68,5 @@ KFileItemClipboard::KFileItemClipboard() connect(QApplication::clipboard(), &QClipboard::dataChanged, this, &KFileItemClipboard::updateCutItems); } + +#include "moc_kfileitemclipboard.cpp" diff --git a/src/kitemviews/private/kitemlistheaderwidget.cpp b/src/kitemviews/private/kitemlistheaderwidget.cpp index 822e9e7a5..850f49406 100644 --- a/src/kitemviews/private/kitemlistheaderwidget.cpp +++ b/src/kitemviews/private/kitemlistheaderwidget.cpp @@ -614,3 +614,5 @@ qreal KItemListHeaderWidget::roleXPosition(const QByteArray &role) const return -1; } + +#include "moc_kitemlistheaderwidget.cpp" diff --git a/src/kitemviews/private/kitemlistkeyboardsearchmanager.cpp b/src/kitemviews/private/kitemlistkeyboardsearchmanager.cpp index c74ef1638..c18f87b7d 100644 --- a/src/kitemviews/private/kitemlistkeyboardsearchmanager.cpp +++ b/src/kitemviews/private/kitemlistkeyboardsearchmanager.cpp @@ -101,3 +101,5 @@ void KItemListKeyboardSearchManager::slotSelectionChanged(const KItemSet ¤ cancelSearch(); } } + +#include "moc_kitemlistkeyboardsearchmanager.cpp" diff --git a/src/kitemviews/private/kitemlistroleeditor.cpp b/src/kitemviews/private/kitemlistroleeditor.cpp index d3389832b..f305fadac 100644 --- a/src/kitemviews/private/kitemlistroleeditor.cpp +++ b/src/kitemviews/private/kitemlistroleeditor.cpp @@ -169,3 +169,5 @@ void KItemListRoleEditor::emitRoleEditingFinished(EditResultDirection direction) Q_EMIT roleEditingFinished(m_role, ret); } } + +#include "moc_kitemlistroleeditor.cpp" diff --git a/src/kitemviews/private/kitemlistrubberband.cpp b/src/kitemviews/private/kitemlistrubberband.cpp index e572780e7..96f87b431 100644 --- a/src/kitemviews/private/kitemlistrubberband.cpp +++ b/src/kitemviews/private/kitemlistrubberband.cpp @@ -74,3 +74,5 @@ bool KItemListRubberBand::isActive() const { return m_active; } + +#include "moc_kitemlistrubberband.cpp" diff --git a/src/kitemviews/private/kitemlistselectiontoggle.cpp b/src/kitemviews/private/kitemlistselectiontoggle.cpp index bec32b3d3..df61b3073 100644 --- a/src/kitemviews/private/kitemlistselectiontoggle.cpp +++ b/src/kitemviews/private/kitemlistselectiontoggle.cpp @@ -99,3 +99,5 @@ int KItemListSelectionToggle::iconSize() const return iconSize; } + +#include "moc_kitemlistselectiontoggle.cpp" diff --git a/src/kitemviews/private/kitemlistsmoothscroller.cpp b/src/kitemviews/private/kitemlistsmoothscroller.cpp index 19d47aac8..3e325b934 100644 --- a/src/kitemviews/private/kitemlistsmoothscroller.cpp +++ b/src/kitemviews/private/kitemlistsmoothscroller.cpp @@ -195,3 +195,5 @@ void KItemListSmoothScroller::handleWheelEvent(QWheelEvent *event) m_smoothScrolling = previous; } + +#include "moc_kitemlistsmoothscroller.cpp" diff --git a/src/kitemviews/private/kitemlistviewanimation.cpp b/src/kitemviews/private/kitemlistviewanimation.cpp index 83a7a2ec6..763f770ff 100644 --- a/src/kitemviews/private/kitemlistviewanimation.cpp +++ b/src/kitemviews/private/kitemlistviewanimation.cpp @@ -234,3 +234,5 @@ void KItemListViewAnimation::slotFinished() } Q_ASSERT(false); } + +#include "moc_kitemlistviewanimation.cpp" diff --git a/src/kitemviews/private/kitemlistviewlayouter.cpp b/src/kitemviews/private/kitemlistviewlayouter.cpp index 027943683..5b0df0bd0 100644 --- a/src/kitemviews/private/kitemlistviewlayouter.cpp +++ b/src/kitemviews/private/kitemlistviewlayouter.cpp @@ -613,3 +613,5 @@ qreal KItemListViewLayouter::minimumGroupHeaderWidth() const { return 100; } + +#include "moc_kitemlistviewlayouter.cpp" |
