[InformationPanel] Use the new inline configuration mode

Summary:
The current external configuration dialog has some issues:

- its layout is suboptimal, as its initial size is typically to small
- it is quite disassociated with the actual widget it configures, properties
  have a different order, and the property names can be quite abstract
  without the corresponding value.

Doing the visibility selection inline typically avoids the sizing problem,
as the containing application (dolphin) is often vertically maximized.
The selection becomes more obvious, as the item order is kept,
and the values are shown.

Depends on D20524

CCBUG: 389571

Reviewers: #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, elvisangelaccio

Reviewed By: #dolphin, elvisangelaccio

Subscribers: elvisangelaccio, meven, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D20525

1 files changed, 0 insertions, 72 deletions

diff --git a/src/panels/information/filemetadataconfigurationdialog.h b/src/panels/information/filemetadataconfigurationdialog.h
deleted file mode 100644
index 0a57cf29f..000000000
--- a/src/panels/information/filemetadataconfigurationdialog.h
+++ /dev/null
@@ -1,72 +0,0 @@
-/***************************************************************************
- *   Copyright (C) 2010 by Peter Penz <[email protected]>             *
- *                                                                         *
- *   This program is free software; you can redistribute it and/or modify  *
- *   it under the terms of the GNU General Public License as published by  *
- *   the Free Software Foundation; either version 2 of the License, or     *
- *   (at your option) any later version.                                   *
- *                                                                         *
- *   This program is distributed in the hope that it will be useful,       *
- *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
- *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
- *   GNU General Public License for more details.                          *
- *                                                                         *
- *   You should have received a copy of the GNU General Public License     *
- *   along with this program; if not, write to the                         *
- *   Free Software Foundation, Inc.,                                       *
- *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA            *
- ***************************************************************************/
-
-#ifndef FILEMETADATACONFIGURATIONDIALOG_H
-#define FILEMETADATACONFIGURATIONDIALOG_H
-
-#include <QDialog>
-
-#include <KFileItem>
-#include <config-baloo.h>
-namespace Baloo {
-    class FileMetaDataConfigWidget;
-}
-
-class QLabel;
-
-/**
- * @brief Dialog which allows to configure which meta data should be shown
- *        in the Baloo:FileMetaDataWidget.
- */
-class FileMetaDataConfigurationDialog : public QDialog
-{
-    Q_OBJECT
-
-public:
-    explicit FileMetaDataConfigurationDialog(QWidget* parent = nullptr);
-    ~FileMetaDataConfigurationDialog() override;
-
-    /**
-     * Sets the items, for which the visibility of the meta data should
-     * be configured. Note that the visibility of the meta data is not
-     * bound to the items itself, the items are only used to determine
-     * which meta data should be configurable. For example when a JPEG image
-     * is set as item, it will be configurable which EXIF data should be
-     * shown. If an audio file is set as item, it will be configurable
-     * whether the artist, album name, ... should be shown.
-     */
-    void setItems(const KFileItemList& items);
-    KFileItemList items() const;
-
-    /**
-     * Sets the description that is shown above the list
-     * of meta data. Per default the translated text for
-     * "Select which data should be shown." is set.
-     */
-    void setDescription(const QString& description);
-    QString description() const;
-
-protected slots:
-    void slotAccepted();
-private:
-    QLabel* m_descriptionLabel;
-    Baloo::FileMetaDataConfigWidget* m_configWidget;
-};
-
-#endif