diff options
| author | Méven Car <[email protected]> | 2019-03-17 17:24:30 +0100 |
|---|---|---|
| committer | Méven Car <[email protected]> | 2019-03-17 19:29:53 +0100 |
| commit | 1ff74854ecb4e5c9a2099759b71c378225c9e988 (patch) | |
| tree | 82e1ec73364f1b1f5b26ca2b3aeced0d70fbacce /src/panels/information/informationpanelcontent.h | |
| parent | 508dc815c75c9db8abaec26ae664ae41bf7f89b5 (diff) | |
Fix a todo: InformationPanelContent::configureSettings code is moved to InformationPanel::contextMenuEvent
Summary:
Fix a TODO : InformationPanelContent::configureSettings code is moved to InformationPanel::contextMenuEvent
Adding necessary accessors and changing visibility of one slot.
Test Plan:
1 compile
2 in dolphin right on the information panel
3 toggle preview
4 from the same context menu, click configure, metadadata settings appears
5 toggle "condensed date" if available
Reviewers: elvisangelaccio, #dolphin
Reviewed By: elvisangelaccio, #dolphin
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D19832
Diffstat (limited to 'src/panels/information/informationpanelcontent.h')
| -rw-r--r-- | src/panels/information/informationpanelcontent.h | 23 |
1 files changed, 10 insertions, 13 deletions
diff --git a/src/panels/information/informationpanelcontent.h b/src/panels/information/informationpanelcontent.h index ca9afab09..a80775aaa 100644 --- a/src/panels/information/informationpanelcontent.h +++ b/src/panels/information/informationpanelcontent.h @@ -72,17 +72,20 @@ public: */ void showItems(const KFileItemList& items); - /** - * Opens a menu which allows to configure which meta information - * should be shown. - * - * TODO: Move this code to the class InformationPanel - */ - void configureSettings(const QList<QAction*>& customContextMenuActions, const QPointF& pos); + void setPreviewVisible(bool visible); + + KFileItemList items(); signals: void urlActivated( const QUrl& url ); +public slots: + /** + * Is invoked after the file meta data configuration dialog has been + * closed and refreshes the visibility of the meta data. + */ + void refreshMetaData(); + protected: /** @see QObject::eventFilter() */ bool eventFilter(QObject* obj, QEvent* event) override; @@ -108,12 +111,6 @@ private slots: void slotHasVideoChanged(bool hasVideo); - /** - * Is invoked after the file meta data configuration dialog has been - * closed and refreshes the visibility of the meta data. - */ - void refreshMetaData(); - private: /** * Sets the text for the label \a m_nameLabel and assures that the |
