After some discussions at http://reviewboard.kde.org/r/1938 it turned out that moving KMetaDataWidget and KMetaDataConfigurationDialog to kdelibs should be postponed to KDE 4.5. The main reason is that adding application specific properties is not possible with the current API in a generic way. Also the topic how to hide properties application specific is an open point...

So now all adjustments from the review have been adapted to the Dolphin code. After KDE 4.4 has been released some refactoring will be done so that the open topics above are handled in a nice way.

svn path=/trunk/KDE/kdebase/apps/; revision=1041547

1 files changed, 0 insertions, 62 deletions

diff --git a/src/panels/information/metadataconfigurationdialog.h b/src/panels/information/metadataconfigurationdialog.h
deleted file mode 100644
index 82dc06ddf..000000000
--- a/src/panels/information/metadataconfigurationdialog.h
+++ /dev/null
@@ -1,62 +0,0 @@
-/***************************************************************************
- *   Copyright (C) 2009 by Peter Penz <[email protected]>                  *
- *                                                                         *
- *   This program is free software; you can redistribute it and/or modify  *
- *   it under the terms of the GNU General Public License as published by  *
- *   the Free Software Foundation; either version 2 of the License, or     *
- *   (at your option) any later version.                                   *
- *                                                                         *
- *   This program is distributed in the hope that it will be useful,       *
- *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
- *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
- *   GNU General Public License for more details.                          *
- *                                                                         *
- *   You should have received a copy of the GNU General Public License     *
- *   along with this program; if not, write to the                         *
- *   Free Software Foundation, Inc.,                                       *
- *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA            *
- ***************************************************************************/
-
-#ifndef META_DATA_CONFIGURATION_DIALOG_H
-#define META_DATA_CONFIGURATION_DIALOG_H
-
-#include <kdialog.h>
-
-class MetaDataWidget;
-
-/**
- * @brief Dialog which allows to configure which meta data should be shown.
- */
-class MetaDataConfigurationDialog : public KDialog
-{
-    Q_OBJECT
-
-public:
-    /**
-     * Allows to configure the visibility of all available meta
-     * data.
-     */
-    MetaDataConfigurationDialog(QWidget* parent = 0,
-                                Qt::WFlags flags = 0);
-
-    /**
-     * Allows to configure the visibility of the meta data
-     * shown by the meta data widget. The number of offered
-     * meta data is optimized for the set of file items
-     * that are applied to the meta data widget.
-     */
-    MetaDataConfigurationDialog(MetaDataWidget* metaDataWidget,
-                                QWidget* parent = 0,
-                                Qt::WFlags flags = 0);
-
-    virtual ~MetaDataConfigurationDialog();
-
-protected slots:
-    virtual void slotButtonClicked(int button);
-
-private:
-    class Private;
-    Private* d;
-};
-
-#endif