diff options
| author | Renato Araujo Oliveira Filho <[email protected]> | 2018-01-19 13:37:09 -0300 |
|---|---|---|
| committer | Renato Araujo Oliveira Filho <[email protected]> | 2018-01-26 11:14:30 -0300 |
| commit | a8a3fa51a0649ffc43b0d740c268e39a6dd6672b (patch) | |
| tree | f89bb52f464dd19733cc546e18a4551c9eb9fa1d /src/panels/places/placesitem.cpp | |
| parent | 3bf68fd71492f02bffb6cf040e9471c5e997180e (diff) | |
Fix place item edit after creation
Summary:
Make sure that the place can be edited after the creation.
Depends on D9333
BUG: 389147
Test Plan:
Create an item in dolphin places panel, make sure that you
can rename it
Reviewers: #dolphin, ngraham
Reviewed By: ngraham
Subscribers: michaelh, elvisangelaccio, lbeltrame, ngraham, #dolphin
Differential Revision: https://phabricator.kde.org/D9985
Diffstat (limited to 'src/panels/places/placesitem.cpp')
| -rw-r--r-- | src/panels/places/placesitem.cpp | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/panels/places/placesitem.cpp b/src/panels/places/placesitem.cpp index d7e87cf7a..3c6023ba8 100644 --- a/src/panels/places/placesitem.cpp +++ b/src/panels/places/placesitem.cpp @@ -129,12 +129,15 @@ Solid::Device PlacesItem::device() const void PlacesItem::setBookmark(const KBookmark& bookmark) { - if (bookmark == m_bookmark) { - return; - } + const bool bookmarkDataChanged = !(bookmark == m_bookmark); + // bookmark object must be updated to keep in sync with source model m_bookmark = bookmark; + if (!bookmarkDataChanged) { + return; + } + delete m_access; delete m_volume; delete m_disc; |