┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/panels
diff options
context:
space:
mode:
authorElvis Angelaccio <[email protected]>2019-11-09 22:45:11 +0100
committerElvis Angelaccio <[email protected]>2019-11-10 10:03:25 +0100
commit2e9f6a7abf6cda1e94be0b448785a3b1f75b5579 (patch)
treec9942850ef16d83853fb40ae88ae512feced6b60 /src/panels
parent16a3aea6a629a91aab937be5c111b64b3ed6cf86 (diff)
PlacesItemModel: remove redundant set of properties
Summary: The text, icon and url properties are already set in `PlacesItem::setBookmark()`, so there is no need to set them here. The `OnlyInApp` property is part of the KBookmark object that we are going to set to the place item, so there is no need to set it here either. Test Plan: - Open both dolphin and the Plasma file dialog in some app - Edit the text, url, icon and the "Only show when using this application" checkbox in some place item from the file dialog - Check whether the place in dolphin keeps getting updated accordingly Reviewers: #dolphin, meven, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25230
Diffstat (limited to 'src/panels')
-rw-r--r--src/panels/places/placesitemmodel.cpp5
1 files changed, 0 insertions, 5 deletions
diff --git a/src/panels/places/placesitemmodel.cpp b/src/panels/places/placesitemmodel.cpp
index 9dbfe7f91..a1223b5fd 100644
--- a/src/panels/places/placesitemmodel.cpp
+++ b/src/panels/places/placesitemmodel.cpp
@@ -588,11 +588,6 @@ void PlacesItemModel::onSourceModelDataChanged(const QModelIndex &topLeft, const
}
if (placeItem && !m_sourceModel->isDevice(sourceIndex)) {
- placeItem->setText(bookmark.text());
- placeItem->setIcon(sourceIndex.data(KFilePlacesModel::IconNameRole).toString());
- placeItem->setUrl(m_sourceModel->url(sourceIndex));
- placeItem->bookmark().setMetaDataItem(QStringLiteral("OnlyInApp"),
- bookmark.metaDataItem(QStringLiteral("OnlyInApp")));
// must update the bookmark object
placeItem->setBookmark(bookmark);
}