KStandardItemModel: Fix inconsistent internal state

Assure that the index-cache is kept consistent with the items when
a removing or inserting is done. A unit-test will be created as soon
as possible.

1 files changed, 2 insertions, 4 deletions

diff --git a/src/panels/places/placesitemmodel.cpp b/src/panels/places/placesitemmodel.cpp
index 21cbf9ed3..14ec54be8 100644
--- a/src/panels/places/placesitemmodel.cpp
+++ b/src/panels/places/placesitemmodel.cpp
@@ -395,7 +395,7 @@ void PlacesItemModel::onItemChanged(int index, const QSet<QByteArray>& changedRo
 {
     const PlacesItem* changedItem = placesItem(index);
     if (changedItem) {
-        // Take care to apply the PlacesItemModel-order of the inserted item
+        // Take care to apply the PlacesItemModel-order of the changed item
         // also to the bookmark-manager.
         const KBookmark insertedBookmark = changedItem->bookmark();
 
@@ -409,9 +409,7 @@ void PlacesItemModel::onItemChanged(int index, const QSet<QByteArray>& changedRo
     }
 
     if (changedRoles.contains("isHidden")) {
-        const PlacesItem* shownItem = placesItem(index);
-        Q_ASSERT(shownItem);
-        if (!m_hiddenItemsShown && shownItem->isHidden()) {
+        if (!m_hiddenItemsShown && changedItem->isHidden()) {
             m_hiddenItemToRemove = index;
             QTimer::singleShot(0, this, SLOT(hideItem()));
         }