Use collapsible box to configure visible roles

Summary:
A modal dialog that opens another modal dialog is bad UX and should be
avoided whenever possible. These days we have `KCollapsibleGroupBox`
that can be used to show advanced settings without cluttering the
default layout.

This change removes the `AdditionalInfoDialog` and uses a collapsible
groupbox instead. The `Apply` buttons gets enabled whenever a role gets
checked or unchecked, consistently with the existing checkboxes.

Test Plan: Change visible roles in the view properties dialog.

Reviewers: #dolphin, #vdg

Reviewed By: #vdg

Subscribers: ngraham, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D13569

1 files changed, 0 insertions, 47 deletions

diff --git a/src/settings/additionalinfodialog.h b/src/settings/additionalinfodialog.h
deleted file mode 100644
index d6bf1e08c..000000000
--- a/src/settings/additionalinfodialog.h
+++ /dev/null
@@ -1,47 +0,0 @@
-/***************************************************************************
- *   Copyright (C) 2007-2012 by Peter Penz <[email protected]>        *
- *                                                                         *
- *   This program is free software; you can redistribute it and/or modify  *
- *   it under the terms of the GNU General Public License as published by  *
- *   the Free Software Foundation; either version 2 of the License, or     *
- *   (at your option) any later version.                                   *
- *                                                                         *
- *   This program is distributed in the hope that it will be useful,       *
- *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
- *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
- *   GNU General Public License for more details.                          *
- *                                                                         *
- *   You should have received a copy of the GNU General Public License     *
- *   along with this program; if not, write to the                         *
- *   Free Software Foundation, Inc.,                                       *
- *   51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA          *
- ***************************************************************************/
-
-#ifndef ADDITIONALINFODIALOG_H
-#define ADDITIONALINFODIALOG_H
-
-#include <QDialog>
-#include <QList>
-#include <QListWidget>
-
-/**
- * @brief Dialog for changing the additional information shown in the view.
- */
-class AdditionalInfoDialog : public QDialog
-{
-    Q_OBJECT
-
-public:
-    AdditionalInfoDialog(QWidget* parent, const QList<QByteArray>& visibleRoles);
-    ~AdditionalInfoDialog() override;
-    QList<QByteArray> visibleRoles() const;
-
-public slots:
-    void accept() override;
-
-private:
-    QList<QByteArray> m_visibleRoles;
-    QListWidget* m_listWidget;
-};
-
-#endif