Dolphin settings revamp

It includes a move of the settings in the Navigation and Startup sections to the Interface (formerly Behavior) section.
It also includes a new tab in the View (formerly View Mode) section, called General where some settings regarding Display style, Browsing and Miscellaneous settings
The Interface section has new tabs named Folders & Tabs and Status & Location bars respectively where most of the Startup and Navigation settings moved.

The `dolphin/kcms/kcm_dolphinnavigation` kcm is removed.

4 files changed, 9 insertions, 151 deletions

diff --git a/src/settings/kcm/kcmdolphingeneral.cpp b/src/settings/kcm/kcmdolphingeneral.cpp
index c002da926..32241d112 100644
--- a/src/settings/kcm/kcmdolphingeneral.cpp
+++ b/src/settings/kcm/kcmdolphingeneral.cpp
@@ -6,9 +6,10 @@
 
 #include "kcmdolphingeneral.h"
 
-#include "settings/general/behaviorsettingspage.h"
-#include "settings/general/confirmationssettingspage.h"
-#include "settings/general/previewssettingspage.h"
+#include "settings/interface/confirmationssettingspage.h"
+#include "settings/interface/folderstabssettingspage.h"
+#include "settings/interface/interfacesettingspage.h"
+#include "settings/interface/previewssettingspage.h"
 
 #include <KLocalizedString>
 #include <KPluginFactory>
@@ -30,10 +31,10 @@ DolphinGeneralConfigModule::DolphinGeneralConfigModule(QWidget *parent, const QV
 
     QTabWidget *tabWidget = new QTabWidget(this);
 
-    // initialize 'Behavior' tab
-    BehaviorSettingsPage *behaviorPage = new BehaviorSettingsPage(QUrl::fromLocalFile(QDir::homePath()), tabWidget);
-    tabWidget->addTab(behaviorPage, i18nc("@title:tab Behavior settings", "Behavior"));
-    connect(behaviorPage, &BehaviorSettingsPage::changed, this, &DolphinGeneralConfigModule::markAsChanged);
+    // initialize 'Folders & Tabs' tab
+    FoldersTabsSettingsPage *foldersTabsPage = new FoldersTabsSettingsPage(tabWidget);
+    tabWidget->addTab(foldersTabsPage, i18nc("@title:tab Behavior settings", "Behavior"));
+    connect(foldersTabsPage, &FoldersTabsSettingsPage::changed, this, &DolphinGeneralConfigModule::markAsChanged);
 
     // initialize 'Previews' tab
     PreviewsSettingsPage *previewsPage = new PreviewsSettingsPage(tabWidget);
@@ -44,7 +45,7 @@ DolphinGeneralConfigModule::DolphinGeneralConfigModule(QWidget *parent, const QV
     ConfirmationsSettingsPage *confirmationsPage = new ConfirmationsSettingsPage(tabWidget);
     tabWidget->addTab(confirmationsPage, i18nc("@title:tab Confirmations settings", "Confirmations"));
     connect(confirmationsPage, &ConfirmationsSettingsPage::changed, this, &DolphinGeneralConfigModule::markAsChanged);
-    m_pages.append(behaviorPage);
+    m_pages.append(foldersTabsPage);
     m_pages.append(previewsPage);
     m_pages.append(confirmationsPage);
 
diff --git a/src/settings/kcm/kcmdolphinnavigation.cpp b/src/settings/kcm/kcmdolphinnavigation.cpp
deleted file mode 100644
index dd4756d8b..000000000
--- a/src/settings/kcm/kcmdolphinnavigation.cpp
+++ /dev/null
@@ -1,48 +0,0 @@
-/*
- * SPDX-FileCopyrightText: 2009 Peter Penz <[email protected]>
- *
- * SPDX-License-Identifier: GPL-2.0-or-later
- */
-
-#include "kcmdolphinnavigation.h"
-
-#include "settings/navigation/navigationsettingspage.h"
-#include <kconfigwidgets_version.h>
-
-#include <KPluginFactory>
-
-#include <QVBoxLayout>
-
-K_PLUGIN_CLASS_WITH_JSON(DolphinNavigationConfigModule, "kcmdolphinnavigation.json")
-
-DolphinNavigationConfigModule::DolphinNavigationConfigModule(QWidget *parent, const QVariantList &args)
-    : KCModule(parent, args)
-    , m_navigation(nullptr)
-{
-    setButtons(KCModule::Default | KCModule::Help | KCModule::Apply);
-
-    QVBoxLayout *topLayout = new QVBoxLayout(this);
-    topLayout->setContentsMargins(0, 0, 0, 0);
-
-    m_navigation = new NavigationSettingsPage(this);
-    connect(m_navigation, &NavigationSettingsPage::changed, this, &DolphinNavigationConfigModule::markAsChanged);
-    topLayout->addWidget(m_navigation, 0, {});
-}
-
-DolphinNavigationConfigModule::~DolphinNavigationConfigModule()
-{
-}
-
-void DolphinNavigationConfigModule::save()
-{
-    m_navigation->applySettings();
-}
-
-void DolphinNavigationConfigModule::defaults()
-{
-    m_navigation->restoreDefaults();
-}
-
-#include "kcmdolphinnavigation.moc"
-
-#include "moc_kcmdolphinnavigation.cpp"
diff --git a/src/settings/kcm/kcmdolphinnavigation.h b/src/settings/kcm/kcmdolphinnavigation.h
deleted file mode 100644
index 97d7bff85..000000000
--- a/src/settings/kcm/kcmdolphinnavigation.h
+++ /dev/null
@@ -1,32 +0,0 @@
-/*
- * SPDX-FileCopyrightText: 2009 Peter Penz <[email protected]>
- *
- * SPDX-License-Identifier: GPL-2.0-or-later
- */
-
-#ifndef KCMDOLPHINNAVIGATION_H
-#define KCMDOLPHINNAVIGATION_H
-
-#include <KCModule>
-
-class NavigationSettingsPage;
-
-/**
- * @brief Allow to configure the Dolphin navigation.
- */
-class DolphinNavigationConfigModule : public KCModule
-{
-    Q_OBJECT
-
-public:
-    DolphinNavigationConfigModule(QWidget *parent, const QVariantList &args);
-    ~DolphinNavigationConfigModule() override;
-
-    void save() override;
-    void defaults() override;
-
-private:
-    NavigationSettingsPage *m_navigation;
-};
-
-#endif
diff --git a/src/settings/kcm/kcmdolphinnavigation.json b/src/settings/kcm/kcmdolphinnavigation.json
deleted file mode 100644
index 8bf2cbfd8..000000000
--- a/src/settings/kcm/kcmdolphinnavigation.json
+++ /dev/null
@@ -1,63 +0,0 @@
-{
-    "KPlugin": {
-        "Icon": "preferences-desktop-navigation",
-        "Name": "Navigation",
-        "Name[ar]": "التّنقّل",
-        "Name[az]": "Naviqasiya",
-        "Name[be]": "Навігацыя",
-        "Name[bg]": "Навигация",
-        "Name[ca@valencia]": "Navegació",
-        "Name[ca]": "Navegació",
-        "Name[cs]": "Navigace",
-        "Name[da]": "Navigation",
-        "Name[de]": "Navigation",
-        "Name[en_GB]": "Navigation",
-        "Name[eo]": "Navigado",
-        "Name[es]": "Navegación",
-        "Name[et]": "Liikumine",
-        "Name[eu]": "Nabigatzea",
-        "Name[fi]": "Selaus",
-        "Name[fr]": "Navigation",
-        "Name[gl]": "Navegación",
-        "Name[he]": "ניווט",
-        "Name[hi]": "संचालन",
-        "Name[hu]": "Navigálás",
-        "Name[ia]": "Navigation",
-        "Name[id]": "Navigasi",
-        "Name[ie]": "Navigation",
-        "Name[is]": "Skoðun",
-        "Name[it]": "Navigazione",
-        "Name[ja]": "ナビゲーション",
-        "Name[ka]": "ნავიგაცია",
-        "Name[ko]": "탐색",
-        "Name[lt]": "Naršymas",
-        "Name[lv]": "Navigācija",
-        "Name[ml]": "നാവിഗേഷന്‍",
-        "Name[my]": "လမ်းညွှန်",
-        "Name[nb]": "Navigasjon",
-        "Name[nl]": "Navigatie",
-        "Name[nn]": "Navigasjon",
-        "Name[pa]": "ਨੇਵੀਗੇਸ਼ਨ",
-        "Name[pl]": "Poruszanie się",
-        "Name[pt]": "Navegação",
-        "Name[pt_BR]": "Navegação",
-        "Name[ro]": "Navigare",
-        "Name[ru]": "Навигация",
-        "Name[se]": "Navigašuvdna",
-        "Name[sk]": "Navigácia",
-        "Name[sl]": "Krmarjenje",
-        "Name[sr@ijekavian]": "Навигација",
-        "Name[sr@ijekavianlatin]": "Navigacija",
-        "Name[sr@latin]": "Navigacija",
-        "Name[sr]": "Навигација",
-        "Name[sv]": "Navigering",
-        "Name[ta]": "உலாவல்",
-        "Name[tr]": "Dolaşım",
-        "Name[uk]": "Навігація",
-        "Name[vi]": "Điều hướng",
-        "Name[x-test]": "xxNavigationxx",
-        "Name[zh_CN]": "导航",
-        "Name[zh_TW]": "導覽"
-    },
-    "X-DocPath": "dolphin/configuring-dolphin.html#preferences-dialog-navigation"
-}