Use collapsible box to configure visible roles

Summary:
A modal dialog that opens another modal dialog is bad UX and should be
avoided whenever possible. These days we have `KCollapsibleGroupBox`
that can be used to show advanced settings without cluttering the
default layout.

This change removes the `AdditionalInfoDialog` and uses a collapsible
groupbox instead. The `Apply` buttons gets enabled whenever a role gets
checked or unchecked, consistently with the existing checkboxes.

Test Plan: Change visible roles in the view properties dialog.

Reviewers: #dolphin, #vdg

Reviewed By: #vdg

Subscribers: ngraham, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D13569

1 files changed, 6 insertions, 4 deletions

diff --git a/src/settings/viewpropertiesdialog.h b/src/settings/viewpropertiesdialog.h
index 35c18718e..80cddbf4e 100644
--- a/src/settings/viewpropertiesdialog.h
+++ b/src/settings/viewpropertiesdialog.h
@@ -1,6 +1,6 @@
 /***************************************************************************
- *   Copyright (C) 2006 by Peter Penz                                      *
- *   [email protected]                                                     *
+ *   Copyright (C) 2006 by Peter Penz <[email protected]>                  *
+ *   Copyright (C) 2018 by Elvis Angelaccio <[email protected]>     *
  *                                                                         *
  *   This program is free software; you can redistribute it and/or modify  *
  *   it under the terms of the GNU General Public License as published by  *
@@ -26,6 +26,8 @@
 #include <QDialog>
 
 class QCheckBox;
+class QListWidget;
+class QListWidgetItem;
 class KComboBox;
 class QPushButton;
 class QRadioButton;
@@ -59,8 +61,8 @@ private slots:
     void slotSortFoldersFirstChanged();
     void slotShowPreviewChanged();
     void slotShowHiddenFilesChanged();
+    void slotItemChanged(QListWidgetItem *item);
     void markAsDirty(bool isDirty);
-    void configureAdditionalInfo();
 
 signals:
     void isDirtyChanged(bool isDirty);
@@ -81,11 +83,11 @@ private:
     QCheckBox* m_previewsShown;
     QCheckBox* m_showInGroups;
     QCheckBox* m_showHiddenFiles;
-    QPushButton* m_additionalInfo;
     QRadioButton* m_applyToCurrentFolder;
     QRadioButton* m_applyToSubFolders;
     QRadioButton* m_applyToAllFolders;
     QCheckBox* m_useAsDefault;
+    QListWidget* m_listWidget;
 };
 
 #endif