diff options
| author | Ahmad Samir <[email protected]> | 2022-06-11 19:16:13 +0200 |
|---|---|---|
| committer | Ahmad Samir <[email protected]> | 2022-06-15 11:28:42 +0200 |
| commit | 28a74d178071c89dbdc53a193c1db68e0d10ddcb (patch) | |
| tree | 5fca06ac39652546c0eb3b289c65fbc1903626d0 /src/settings | |
| parent | 8a0003bfbcc87068737ab1e2b94ae7b2ba73eca1 (diff) | |
Use cmakedefine01
This way we get a build time warning if the var isn't defined at all, e.g.
a missing check_include_files() CMake call.
Diffstat (limited to 'src/settings')
| -rw-r--r-- | src/settings/contextmenu/servicemenuinstaller/servicemenuinstaller.cpp | 6 | ||||
| -rw-r--r-- | src/settings/dolphinsettingsdialog.cpp | 6 | ||||
| -rw-r--r-- | src/settings/general/behaviorsettingspage.cpp | 10 | ||||
| -rw-r--r-- | src/settings/general/confirmationssettingspage.cpp | 12 | ||||
| -rw-r--r-- | src/settings/general/confirmationssettingspage.h | 2 | ||||
| -rw-r--r-- | src/settings/viewpropertiesdialog.cpp | 4 |
6 files changed, 20 insertions, 20 deletions
diff --git a/src/settings/contextmenu/servicemenuinstaller/servicemenuinstaller.cpp b/src/settings/contextmenu/servicemenuinstaller/servicemenuinstaller.cpp index 3e9b7d060..9a6d2f6d6 100644 --- a/src/settings/contextmenu/servicemenuinstaller/servicemenuinstaller.cpp +++ b/src/settings/contextmenu/servicemenuinstaller/servicemenuinstaller.cpp @@ -29,7 +29,7 @@ enum PackageOperation { Uninstall }; -#ifdef HAVE_PACKAGEKIT +#if HAVE_PACKAGEKIT #include <PackageKit/Daemon> #include <PackageKit/Details> #include <PackageKit/Transaction> @@ -53,7 +53,7 @@ QString getServiceMenusDir() return QDir(dataLocation).absoluteFilePath("kio/servicemenus"); } -#ifdef HAVE_PACKAGEKIT +#if HAVE_PACKAGEKIT void packageKitInstall(const QString &fileName) { PackageKit::Transaction *transaction = PackageKit::Daemon::installFile(fileName, PackageKit::Transaction::TransactionFlagNone); @@ -111,7 +111,7 @@ void packageKitUninstall(const QString &fileName) Q_NORETURN void packageKit(PackageOperation operation, const QString &fileName) { -#ifdef HAVE_PACKAGEKIT +#if HAVE_PACKAGEKIT QFileInfo fileInfo(fileName); if (!fileInfo.exists()) { fail(i18n("The file does not exist!")); diff --git a/src/settings/dolphinsettingsdialog.cpp b/src/settings/dolphinsettingsdialog.cpp index ea32065e0..f6c4c8308 100644 --- a/src/settings/dolphinsettingsdialog.cpp +++ b/src/settings/dolphinsettingsdialog.cpp @@ -15,7 +15,7 @@ #include "trash/trashsettingspage.h" #include "viewmodes/viewsettingspage.h" #include "config-dolphin.h" -#ifdef HAVE_KUSERFEEDBACK +#if HAVE_KUSERFEEDBACK #include "userfeedback/dolphinfeedbackprovider.h" #include "userfeedback/userfeedbacksettingspage.h" #endif @@ -105,7 +105,7 @@ DolphinSettingsDialog::DolphinSettingsDialog(const QUrl& url, QWidget* parent, K connect(trashSettingsPage, &TrashSettingsPage::changed, this, &DolphinSettingsDialog::enableApply); } -#ifdef HAVE_KUSERFEEDBACK +#if HAVE_KUSERFEEDBACK // User Feedback UserFeedbackSettingsPage* feedbackSettingsPage = nullptr; if (DolphinFeedbackProvider::instance()->isEnabled()) { @@ -124,7 +124,7 @@ DolphinSettingsDialog::DolphinSettingsDialog(const QUrl& url, QWidget* parent, K if (trashSettingsPage) { m_pages.append(trashSettingsPage); } -#ifdef HAVE_KUSERFEEDBACK +#if HAVE_KUSERFEEDBACK if (feedbackSettingsPage) { m_pages.append(feedbackSettingsPage); } diff --git a/src/settings/general/behaviorsettingspage.cpp b/src/settings/general/behaviorsettingspage.cpp index 5ca0566a9..4e78447c7 100644 --- a/src/settings/general/behaviorsettingspage.cpp +++ b/src/settings/general/behaviorsettingspage.cpp @@ -65,7 +65,7 @@ BehaviorSettingsPage::BehaviorSettingsPage(const QUrl& url, QWidget* parent) : topLayout->addItem(new QSpacerItem(0, Dolphin::VERTICAL_SPACER_HEIGHT, QSizePolicy::Fixed, QSizePolicy::Fixed)); -#ifdef HAVE_BALOO +#if HAVE_BALOO // 'Show tooltips' m_showToolTips = new QCheckBox(i18nc("@option:check", "Show tooltips")); topLayout->addRow(i18nc("@title:group", "Miscellaneous: "), m_showToolTips); @@ -73,7 +73,7 @@ BehaviorSettingsPage::BehaviorSettingsPage(const QUrl& url, QWidget* parent) : // 'Show selection marker' m_showSelectionToggle = new QCheckBox(i18nc("@option:check", "Show selection marker")); -#ifdef HAVE_BALOO +#if HAVE_BALOO topLayout->addRow(QString(), m_showSelectionToggle); #else topLayout->addRow(i18nc("@title:group", "Miscellaneous: "), m_showSelectionToggle); @@ -96,7 +96,7 @@ BehaviorSettingsPage::BehaviorSettingsPage(const QUrl& url, QWidget* parent) : connect(m_localViewProps, &QRadioButton::toggled, this, &BehaviorSettingsPage::changed); connect(m_globalViewProps, &QRadioButton::toggled, this, &BehaviorSettingsPage::changed); -#ifdef HAVE_BALOO +#if HAVE_BALOO connect(m_showToolTips, &QCheckBox::toggled, this, &BehaviorSettingsPage::changed); #endif connect(m_showSelectionToggle, &QCheckBox::toggled, this, &BehaviorSettingsPage::changed); @@ -119,7 +119,7 @@ void BehaviorSettingsPage::applySettings() const bool useGlobalViewProps = m_globalViewProps->isChecked(); settings->setGlobalViewProps(useGlobalViewProps); -#ifdef HAVE_BALOO +#if HAVE_BALOO settings->setShowToolTips(m_showToolTips->isChecked()); #endif settings->setShowSelectionToggle(m_showSelectionToggle->isChecked()); @@ -153,7 +153,7 @@ void BehaviorSettingsPage::loadSettings() m_localViewProps->setChecked(!useGlobalViewProps); m_globalViewProps->setChecked(useGlobalViewProps); -#ifdef HAVE_BALOO +#if HAVE_BALOO m_showToolTips->setChecked(GeneralSettings::showToolTips()); #endif m_showSelectionToggle->setChecked(GeneralSettings::showSelectionToggle()); diff --git a/src/settings/general/confirmationssettingspage.cpp b/src/settings/general/confirmationssettingspage.cpp index 66a2bb9bf..af4e2877f 100644 --- a/src/settings/general/confirmationssettingspage.cpp +++ b/src/settings/general/confirmationssettingspage.cpp @@ -37,7 +37,7 @@ ConfirmationsSettingsPage::ConfirmationsSettingsPage(QWidget* parent) : m_confirmEmptyTrash(nullptr), m_confirmDelete(nullptr), -#ifdef HAVE_TERMINAL +#if HAVE_TERMINAL m_confirmClosingTerminalRunningProgram(nullptr), #endif @@ -61,7 +61,7 @@ ConfirmationsSettingsPage::ConfirmationsSettingsPage(QWidget* parent) : m_confirmClosingMultipleTabs = new QCheckBox(i18nc("@option:check Ask for confirmation in Dolphin when", "Closing windows with multiple tabs"), this); -#ifdef HAVE_TERMINAL +#if HAVE_TERMINAL m_confirmClosingTerminalRunningProgram = new QCheckBox(i18nc("@option:check Ask for confirmation when", "Closing windows with a program running in the Terminal panel"), this); #endif @@ -83,7 +83,7 @@ ConfirmationsSettingsPage::ConfirmationsSettingsPage(QWidget* parent) : topLayout->addWidget(confirmLabelDolphin); topLayout->addWidget(m_confirmClosingMultipleTabs); -#ifdef HAVE_TERMINAL +#if HAVE_TERMINAL topLayout->addWidget(m_confirmClosingTerminalRunningProgram); #endif @@ -100,7 +100,7 @@ ConfirmationsSettingsPage::ConfirmationsSettingsPage(QWidget* parent) : connect(m_confirmScriptExecution, QOverload<int>::of(&QComboBox::currentIndexChanged), this, &ConfirmationsSettingsPage::changed); connect(m_confirmClosingMultipleTabs, &QCheckBox::toggled, this, &ConfirmationsSettingsPage::changed); -#ifdef HAVE_TERMINAL +#if HAVE_TERMINAL connect(m_confirmClosingTerminalRunningProgram, &QCheckBox::toggled, this, &ConfirmationsSettingsPage::changed); #endif } @@ -135,7 +135,7 @@ void ConfirmationsSettingsPage::applySettings() GeneralSettings* settings = GeneralSettings::self(); settings->setConfirmClosingMultipleTabs(m_confirmClosingMultipleTabs->isChecked()); -#ifdef HAVE_TERMINAL +#if HAVE_TERMINAL settings->setConfirmClosingTerminalRunningProgram(m_confirmClosingTerminalRunningProgram->isChecked()); #endif @@ -175,7 +175,7 @@ void ConfirmationsSettingsPage::loadSettings() m_confirmClosingMultipleTabs->setChecked(GeneralSettings::confirmClosingMultipleTabs()); -#ifdef HAVE_TERMINAL +#if HAVE_TERMINAL m_confirmClosingTerminalRunningProgram->setChecked(GeneralSettings::confirmClosingTerminalRunningProgram()); #endif } diff --git a/src/settings/general/confirmationssettingspage.h b/src/settings/general/confirmationssettingspage.h index aa8fbbe40..09ba56886 100644 --- a/src/settings/general/confirmationssettingspage.h +++ b/src/settings/general/confirmationssettingspage.h @@ -37,7 +37,7 @@ private: QCheckBox* m_confirmEmptyTrash; QCheckBox* m_confirmDelete; -#ifdef HAVE_TERMINAL +#if HAVE_TERMINAL QCheckBox* m_confirmClosingTerminalRunningProgram; #endif diff --git a/src/settings/viewpropertiesdialog.cpp b/src/settings/viewpropertiesdialog.cpp index 318c2e1cf..6e3cc81ab 100644 --- a/src/settings/viewpropertiesdialog.cpp +++ b/src/settings/viewpropertiesdialog.cpp @@ -19,7 +19,7 @@ #include <KMessageBox> #include <KWindowConfig> -#ifdef HAVE_BALOO +#if HAVE_BALOO #include <Baloo/IndexerConfig> #endif @@ -108,7 +108,7 @@ ViewPropertiesDialog::ViewPropertiesDialog(DolphinView* dolphinView) : // Add checkboxes bool indexingEnabled = false; -#ifdef HAVE_BALOO +#if HAVE_BALOO Baloo::IndexerConfig config; indexingEnabled = config.fileIndexingEnabled(); #endif |
