Add a second Dolphin unit test (for a regression in DolphinDetailsView

which has been fixed recently). This commit also adds a new class
TestHelper which provides some funtionality that most Dolphin unit
tests will need. I hope that this makes implementing additional tests
as easy as possible :-)

svn path=/trunk/KDE/kdebase/apps/; revision=1188536

1 files changed, 123 insertions, 0 deletions

diff --git a/src/tests/dolphindetailsviewtest.cpp b/src/tests/dolphindetailsviewtest.cpp
new file mode 100644
index 000000000..dc5c94a6b
--- /dev/null
+++ b/src/tests/dolphindetailsviewtest.cpp
@@ -0,0 +1,123 @@
+/***************************************************************************
+ *   Copyright (C) 2010 by Frank Reininghaus ([email protected])    *
+ *                                                                         *
+ *   This program is free software; you can redistribute it and/or modify  *
+ *   it under the terms of the GNU General Public License as published by  *
+ *   the Free Software Foundation; either version 2 of the License, or     *
+ *   (at your option) any later version.                                   *
+ *                                                                         *
+ *   This program is distributed in the hope that it will be useful,       *
+ *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
+ *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
+ *   GNU General Public License for more details.                          *
+ *                                                                         *
+ *   You should have received a copy of the GNU General Public License     *
+ *   along with this program; if not, write to the                         *
+ *   Free Software Foundation, Inc.,                                       *
+ *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA            *
+ ***************************************************************************/
+
+#include <qtest_kde.h>
+
+#include "testhelper.h"
+
+#include "views/dolphindetailsview.h"
+#include "views/dolphinview.h"
+#include "views/dolphinmodel.h"
+#include "views/dolphindirlister.h"
+#include "views/dolphinsortfilterproxymodel.h"
+#include "views/zoomlevelinfo.h"
+
+#include <KTempDir>
+
+#include <QtCore/QDir>
+
+#include "kdebug.h"
+
+class DolphinDetailsViewTest : public QObject
+{
+    Q_OBJECT
+
+private slots:
+
+    void initTestCase();
+    void cleanupTestCase();
+
+    void bug234600_overlappingIconsWhenZooming();
+
+private:
+
+    TestHelper* m_helper;
+    DolphinView* m_view;
+};
+
+void DolphinDetailsViewTest::initTestCase()
+{
+    m_helper = new TestHelper;
+    m_view = m_helper->view();
+}
+
+void DolphinDetailsViewTest::cleanupTestCase()
+{
+    delete m_helper;
+}
+
+/**
+ * When the icon size is changed, we have to make sure that the maximumSize given
+ * to KFileItemDelegate for rendering each item is updated correctly. If this is not
+ * done, the visualRects are clipped by the incorrect maximum size, and the icons
+ * may overlap, see
+ *
+ * https://bugs.kde.org/show_bug.cgi?id=234600
+ */
+
+void DolphinDetailsViewTest::bug234600_overlappingIconsWhenZooming()
+{
+    QStringList files;
+    files << "a" << "b" << "c" << "d";
+    m_helper->createFiles(files);
+
+    m_view->setMode(DolphinView::DetailsView);
+    DolphinDetailsView* detailsView = qobject_cast<DolphinDetailsView*>(m_helper->itemView());
+    QVERIFY(detailsView);
+    m_view->resize(400, 400);
+    m_view->show();
+    QTest::qWaitForWindowShown(m_view);
+
+    // We have to make sure that the view has loaded the directory before we start the test.
+    // TODO: This will be needed frequently. Maybe move to TestHelper.
+    QSignalSpy finished(m_view, SIGNAL(finishedPathLoading(const KUrl&)));
+    m_view->reload();
+    while (finished.count() != 1) {
+        QTest::qWait(50);
+    }
+
+    QModelIndex index0 = detailsView->model()->index(0, 0);
+    detailsView->setCurrentIndex(index0);
+    QCOMPARE(detailsView->currentIndex(), index0);
+
+    // Setting the zoom level to the minimum value and triggering DolphinDetailsView::currentChanged(...)
+    // should make sure that the bug is triggered.
+    int zoomLevel = ZoomLevelInfo::minimumLevel();
+    m_view->setZoomLevel(zoomLevel);
+
+    QModelIndex index1 = detailsView->model()->index(1, 0);
+    detailsView->setCurrentIndex(index1);
+    QCOMPARE(detailsView->currentIndex(), index1);
+
+    // Increase the zoom level successively to the maximum.
+    while(zoomLevel < ZoomLevelInfo::maximumLevel()) {
+        zoomLevel++;
+        m_view->setZoomLevel(zoomLevel);
+
+        //Check for each zoom level that the height of each item is at least the icon size.
+        QVERIFY(detailsView->visualRect(index1).height() >= ZoomLevelInfo::iconSizeForZoomLevel(zoomLevel));
+    }
+
+    m_view->hide();
+    m_helper->cleanupTestDir();
+}
+
+QTEST_KDEMAIN(DolphinDetailsViewTest, GUI)
+
+#include "dolphindetailsviewtest.moc"
\ No newline at end of file