diff options
| author | Elvis Angelaccio <[email protected]> | 2019-01-05 17:29:34 +0100 |
|---|---|---|
| committer | Elvis Angelaccio <[email protected]> | 2019-01-05 17:29:34 +0100 |
| commit | 504db3f702625c63cb304430e60ab21b9411cb96 (patch) | |
| tree | b35f45053e991800831d1994f033b62b8c84b32e /src/tests/dolphinmainwindowtest.cpp | |
| parent | 1cde03cdfe66f455e115a373878524b227fadc4e (diff) | |
Fix title update when changing active split view
Summary:
The DolphinTabPage::activeViewUrlChanged signal triggers the title
update in DolphinMainWindow, which sets the new title from the
`m_activeViewContainer` instance.
This means we need to notify the main window that the active view
changed before telling it that the current url changed.
BUG: 402641
FIXED-IN: 18.12.1
Reviewers: #dolphin, rizzitello, ngraham
Reviewed By: #dolphin, rizzitello, ngraham
Subscribers: rizzitello, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D17881
Diffstat (limited to 'src/tests/dolphinmainwindowtest.cpp')
| -rw-r--r-- | src/tests/dolphinmainwindowtest.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/tests/dolphinmainwindowtest.cpp b/src/tests/dolphinmainwindowtest.cpp index d7ff1fb54..9cc6b84e8 100644 --- a/src/tests/dolphinmainwindowtest.cpp +++ b/src/tests/dolphinmainwindowtest.cpp @@ -203,7 +203,6 @@ void DolphinMainWindowTest::testUpdateWindowTitleAfterChangingSplitView() // Activate back the left view and check whether the old title gets restored. leftViewContainer->setActive(true); - QEXPECT_FAIL("", "Bug #402641", Continue); QCOMPARE(m_mainWindow->windowTitle(), oldTitle); } |