diff options
| author | Alexander Lohnau <[email protected]> | 2020-10-23 19:48:22 +0200 |
|---|---|---|
| committer | Elvis Angelaccio <[email protected]> | 2020-10-23 18:23:06 +0000 |
| commit | a24327cd50ef17b953ecb908d260b73460158107 (patch) | |
| tree | b0fdaf2b2ab6cc4df0d471b3f1e9f449be71aa33 /src/tests | |
| parent | 360a8dd883f7e281c0a3f2ae729450790399bf3d (diff) | |
Compile without foreach
Diffstat (limited to 'src/tests')
| -rw-r--r-- | src/tests/kfileitemmodelbenchmark.cpp | 4 | ||||
| -rw-r--r-- | src/tests/kitemlistcontrollertest.cpp | 8 | ||||
| -rw-r--r-- | src/tests/kitemsettest.cpp | 10 | ||||
| -rw-r--r-- | src/tests/testdir.cpp | 4 |
4 files changed, 13 insertions, 13 deletions
diff --git a/src/tests/kfileitemmodelbenchmark.cpp b/src/tests/kfileitemmodelbenchmark.cpp index 75f81678d..37874cea8 100644 --- a/src/tests/kfileitemmodelbenchmark.cpp +++ b/src/tests/kfileitemmodelbenchmark.cpp @@ -67,7 +67,7 @@ void KFileItemModelBenchmark::insertAndRemoveManyItems_data() QList<int> sizes; sizes << 100000; - foreach (int n, sizes) { + for (int n : qAsConst(sizes)) { QStringList allStrings; for (int i = 0; i < n; ++i) { allStrings << QString::number(i); @@ -197,7 +197,7 @@ KFileItemList KFileItemModelBenchmark::createFileItemList(const QStringList& fil qInstallMessageHandler(myMessageOutput); KFileItemList result; - foreach (const QString& name, fileNames) { + for (const QString& name : fileNames) { const KFileItem item(QUrl::fromLocalFile(prefix + name), QString(), KFileItem::Unknown); result << item; } diff --git a/src/tests/kitemlistcontrollertest.cpp b/src/tests/kitemlistcontrollertest.cpp index 7bc6b5d99..80b88c03e 100644 --- a/src/tests/kitemlistcontrollertest.cpp +++ b/src/tests/kitemlistcontrollertest.cpp @@ -241,7 +241,7 @@ void KItemListControllerTest::testKeyboardNavigation_data() groupingEnabledList.append(true); groupingEnabledNames[true] = "grouping enabled"; - foreach (const KFileItemListView::ItemLayout& layout, layoutList) { + for (const KFileItemListView::ItemLayout& layout : layoutList) { // The following settings depend on the layout. // Note that 'columns' are actually 'rows' in // Compact layout. @@ -279,9 +279,9 @@ void KItemListControllerTest::testKeyboardNavigation_data() break; } - foreach (int columnCount, columnCountList) { - foreach (const KItemListController::SelectionBehavior& selectionBehavior, selectionBehaviorList) { - foreach (bool groupingEnabled, groupingEnabledList) { // krazy:exclude=foreach + for (int columnCount : qAsConst(columnCountList)) { + for (const KItemListController::SelectionBehavior& selectionBehavior : qAsConst(selectionBehaviorList)) { + for (bool groupingEnabled : qAsConst(groupingEnabledList)) { QList<QPair<KeyPress, ViewState> > testList; // First, key presses which should have the same effect diff --git a/src/tests/kitemsettest.cpp b/src/tests/kitemsettest.cpp index 880d9d966..d19752c33 100644 --- a/src/tests/kitemsettest.cpp +++ b/src/tests/kitemsettest.cpp @@ -16,7 +16,7 @@ Q_DECLARE_METATYPE(KItemRangeList) KItemSet KItemRangeList2KItemSet(const KItemRangeList& itemRanges) { KItemSet result; - foreach (const KItemRange& range, itemRanges) { + for (const KItemRange& range : itemRanges) { for (int i = range.index; i < range.index + range.count; ++i) { result.insert(i); } @@ -30,7 +30,7 @@ KItemSet KItemRangeList2KItemSet(const KItemRangeList& itemRanges) QSet<int> KItemRangeList2QSet(const KItemRangeList& itemRanges) { QSet<int> result; - foreach (const KItemRange& range, itemRanges) { + for (const KItemRange& range : itemRanges) { for (int i = range.index; i < range.index + range.count; ++i) { result.insert(i); } @@ -44,7 +44,7 @@ QSet<int> KItemRangeList2QSet(const KItemRangeList& itemRanges) QVector<int> KItemRangeList2QVector(const KItemRangeList& itemRanges) { QVector<int> result; - foreach (const KItemRange& range, itemRanges) { + for (const KItemRange& range : itemRanges) { for (int i = range.index; i < range.index + range.count; ++i) { result.append(i); } @@ -65,11 +65,11 @@ static QSet<int> KItemSet2QSet(const KItemSet& itemSet) // Check that the conversion was successful. Q_ASSERT(itemSet.count() == result.count()); - for (int i : itemSet) { + for (int i : qAsConst(itemSet)) { Q_ASSERT(result.contains(i)); } - foreach (int i, result) { + for (int i : qAsConst(result)) { Q_ASSERT(itemSet.contains(i)); } diff --git a/src/tests/testdir.cpp b/src/tests/testdir.cpp index 29bb3ad78..51dbdbc58 100644 --- a/src/tests/testdir.cpp +++ b/src/tests/testdir.cpp @@ -61,7 +61,7 @@ void TestDir::createFile(const QString& path, const QByteArray& data, const QDat void TestDir::createFiles(const QStringList& files) { - foreach (const QString& path, files) { + for (const QString& path : files) { createFile(path); } } @@ -81,7 +81,7 @@ void TestDir::createDir(const QString& path, const QDateTime& time) void TestDir::removeFiles(const QStringList& files) { - foreach (const QString& path, files) { + for (const QString& path : files) { removeFile(path); } } |
