diff options
| author | Nate Graham <[email protected]> | 2019-08-24 14:33:00 -0600 |
|---|---|---|
| committer | Nate Graham <[email protected]> | 2019-09-09 07:17:17 -0600 |
| commit | 60d6a3bdbcd44360e1c6ae1c82239ecf6d60ded7 (patch) | |
| tree | 940e4c7d8cff5f186eba70ad407b527f95fe71c0 /src/views/dolphinviewactionhandler.cpp | |
| parent | a6403716439ae72bfdf86a14af94ea9d212f08ee (diff) | |
Fix ascending/descending choosers getting unchecked when re-selecting the same sort order
Summary:
When you select the same sort order that's already selected, the currently-checked
sort order description (the human-readable ascending/descending items) gets unchecked
in `slotSortTriggered()` yet the ascending/descending items items only get checked in
`slotSortOrderChanged()`. Because the order hasn't gotten changed, neither one gets
checked again.
This patch fixes the problem by not unchecking them in the first place.
BUG: 411223
FIXED-IN: 19.08.2
Test Plan:
1. Right-click > Sort By > Click the currently-selected sort order
2. Right-click > Sort By > See that the item for the current ascending/descending setting has not been changed
Reviewers: elvisangelaccio, #dolphin
Reviewed By: elvisangelaccio, #dolphin
Subscribers: broulik, meven, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D23412
Diffstat (limited to 'src/views/dolphinviewactionhandler.cpp')
| -rw-r--r-- | src/views/dolphinviewactionhandler.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/views/dolphinviewactionhandler.cpp b/src/views/dolphinviewactionhandler.cpp index 41752e4f1..a79dacb1f 100644 --- a/src/views/dolphinviewactionhandler.cpp +++ b/src/views/dolphinviewactionhandler.cpp @@ -637,9 +637,10 @@ void DolphinViewActionHandler::slotSortTriggered(QAction* action) // and several sub-menus. Because of this they don't have a common // action-group that assures an exclusive toggle-state between the main-menu // actions and the sub-menu-actions. If an action gets checked, it must - // be assured that all other actions get unchecked. + // be assured that all other actions get unchecked, except the ascending/ + // descending actions QAction* sortByMenu = m_actionCollection->action(QStringLiteral("sort")); - foreach (QAction* groupAction, sortByMenu->menu()->actions()) { + for (QAction *groupAction : qAsConst(m_sortByActions)) { KActionMenu* actionMenu = qobject_cast<KActionMenu*>(groupAction); if (actionMenu) { foreach (QAction* subAction, actionMenu->menu()->actions()) { |