┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/views/draganddrophelper.h
diff options
context:
space:
mode:
authorRafał Lichwała <[email protected]>2026-02-13 17:10:05 +0100
committerMéven Car <[email protected]>2026-02-15 10:22:01 +0000
commitaa229c536b84d120e0b74661db10044f64d5a5b2 (patch)
treecda6efb6b162bb79770d6f141d7573531ab934a0 /src/views/draganddrophelper.h
parent768c59f4669cd0e32f48d0ca65fa62b3c71eefb5 (diff)
dolphinview: indicate drops from Places view
This commit corrects previous attempt of bug fix done in https://invent.kde.org/frameworks/kio/-/commit/71b2b38b0c4fc4c7820fd95b031413d854d8f8c6?merge_request_iid=2074 which incorrectly recognized drop action from Places View (based only on missing Qt::MoveAction which had side effects described in BUG 514697) This time DolphinView indicates that the given dropEvent comes from Places View so we must avoid potentially destructive Move-like plugins actions. This is done by setting proper KIO::DropJobFlags additional flag for KIO::drop(). CCBUG: 509231 CCBUG: 514697
Diffstat (limited to 'src/views/draganddrophelper.h')
-rw-r--r--src/views/draganddrophelper.h17
1 files changed, 10 insertions, 7 deletions
diff --git a/src/views/draganddrophelper.h b/src/views/draganddrophelper.h
index 73043febc..45f7e5dc9 100644
--- a/src/views/draganddrophelper.h
+++ b/src/views/draganddrophelper.h
@@ -11,6 +11,7 @@
#include "dolphin_export.h"
#include <KFileItem>
+#include <KIO/DropJob>
#include <QList>
#include <QString>
@@ -33,14 +34,16 @@ public:
* offered to the user. The drag destination must represent a directory or
* a desktop-file, otherwise the dropping gets ignored.
*
- * @param destUrl URL of the item destination. Is used only if destItem::isNull()
- * is true.
- * @param event Drop event.
- * @param window Widget where the drop happened, will be used as parent of the drop menu.
- * @return KIO::DropJob pointer or null in case the destUrl is contained
- * in the mimeData url list.
+ * @param destUrl URL of the item destination. Is used only if destItem::isNull()
+ * is true.
+ * @param event Drop event.
+ * @param window Widget where the drop happened, will be used as parent of the drop menu.
+ * @param dropjobFlags Additional KIO::DropJobFlags passed to KIO::drop
+ * @return KIO::DropJob pointer or null in case the destUrl is contained
+ * in the mimeData url list.
*/
- static KIO::DropJob *dropUrls(const QUrl &destUrl, QDropEvent *event, QWidget *window);
+ static KIO::DropJob *
+ dropUrls(const QUrl &destUrl, QDropEvent *event, QWidget *window, KIO::DropJobFlags dropjobFlags = KIO::DropJobFlag::DropJobDefaultFlags);
/**
* Checks if the destination supports dropping.