┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorFelix Ernst <[email protected]>2020-11-05 16:28:13 +0100
committerElvis Angelaccio <[email protected]>2020-11-09 23:49:07 +0100
commit42023831374496c62708ce7ad2cdd69104a1c820 (patch)
treec99126bd099efab242ce002b4945dc96527e8935 /src
parenta418d6229e31dac254660da2a417b4306f066ae3 (diff)
Apply Méven Car's suggestions
Diffstat (limited to 'src')
-rw-r--r--src/dolphinmainwindow.cpp9
-rw-r--r--src/dolphinnavigatorswidgetaction.cpp15
2 files changed, 12 insertions, 12 deletions
diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp
index 8b389ce9b..e3435685f 100644
--- a/src/dolphinmainwindow.cpp
+++ b/src/dolphinmainwindow.cpp
@@ -143,9 +143,6 @@ DolphinMainWindow::DolphinMainWindow() :
setAcceptDrops(true);
auto *navigatorsWidgetAction = new DolphinNavigatorsWidgetAction(this);
- navigatorsWidgetAction->setText(i18nc(
- "@action:inmenu When split view is enabled there are two otherwise one.",
- "Url Navigator(s)"));
actionCollection()->addAction(QStringLiteral("url_navigators"), navigatorsWidgetAction);
m_tabWidget = new DolphinTabWidget(navigatorsWidgetAction, this);
m_tabWidget->setObjectName("tabWidget");
@@ -915,17 +912,17 @@ void DolphinMainWindow::goBack()
void DolphinMainWindow::goForward()
{
- m_activeViewContainer->urlNavigator()->goForward();
+ m_activeViewContainer->urlNavigatorInternalWithHistory()->goForward();
}
void DolphinMainWindow::goUp()
{
- m_activeViewContainer->urlNavigator()->goUp();
+ m_activeViewContainer->urlNavigatorInternalWithHistory()->goUp();
}
void DolphinMainWindow::goHome()
{
- m_activeViewContainer->urlNavigator()->goHome();
+ m_activeViewContainer->urlNavigatorInternalWithHistory()->goHome();
}
void DolphinMainWindow::goBackInNewTab()
diff --git a/src/dolphinnavigatorswidgetaction.cpp b/src/dolphinnavigatorswidgetaction.cpp
index bd2985d47..11140347a 100644
--- a/src/dolphinnavigatorswidgetaction.cpp
+++ b/src/dolphinnavigatorswidgetaction.cpp
@@ -27,7 +27,10 @@ DolphinNavigatorsWidgetAction::DolphinNavigatorsWidgetAction(QWidget *parent) :
m_globalXOfSecondary{-1},
m_widthOfSecondary{-1}
{
- setText(i18nc("@action:inmenu", "Url navigator"));
+ setText(i18nc(
+ "@action:inmenu When split view is enabled there are two otherwise one.",
+ "Url Navigator(s)"));
+ setIcon(QIcon::fromTheme(QStringLiteral("dialog-scripts")));
m_splitter->setChildrenCollapsible(false);
setDefaultWidget(m_splitter.get());
@@ -55,7 +58,7 @@ bool DolphinNavigatorsWidgetAction::addToToolbarAndSave(KXmlGuiWindow *mainWindo
QDomElement urlNavigatorElement = domDocument.createElement(QStringLiteral("Action"));
urlNavigatorElement.setAttribute(QStringLiteral("name"), QStringLiteral("url_navigators"));
- QDomNode position = toolbar.lastChildElement(QStringLiteral("Spacer"));
+ QDomNode position = toolbar.firstChildElement(QStringLiteral("Spacer"));
if (position.isNull()) {
toolbar.appendChild(urlNavigatorElement);
} else {
@@ -193,10 +196,10 @@ QWidget *DolphinNavigatorsWidgetAction::createNavigatorWidget(Side side) const
layout->addWidget(emptyTrashButton);
connect(urlNavigator, &KUrlNavigator::urlChanged, [this]() {
- // We have to wait for DolphinUrlNavigator::sizeHint() to update which
- // happens a little bit later than when urlChanged is emitted.
- this->m_adjustSpacingTimer->start();
- });
+ // We have to wait for DolphinUrlNavigator::sizeHint() to update which
+ // happens a little bit later than when urlChanged is emitted.
+ this->m_adjustSpacingTimer->start();
+ });
auto trailingSpacing = new QWidget{navigatorWidget};
layout->addWidget(trailingSpacing);