revert last commit, it leads to the uncommon behavior that the last state of the settings dialog is remembered (grmpf - I should do more testing... ;-))

svn path=/trunk/KDE/kdebase/apps/; revision=661511

3 files changed, 15 insertions, 24 deletions

diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp
index 2057c05d5..b87b3cb08 100644
--- a/src/dolphinmainwindow.cpp
+++ b/src/dolphinmainwindow.cpp
@@ -950,7 +950,8 @@ void DolphinMainWindow::compareFiles()
 
 void DolphinMainWindow::editSettings()
 {
-    DolphinSettingsDialog::instance(this).exec();
+    DolphinSettingsDialog dialog(this);
+    dialog.exec();
 }
 
 void DolphinMainWindow::init()
diff --git a/src/dolphinsettingsdialog.cpp b/src/dolphinsettingsdialog.cpp
index 3ac70de02..7f8c50cca 100644
--- a/src/dolphinsettingsdialog.cpp
+++ b/src/dolphinsettingsdialog.cpp
@@ -26,27 +26,6 @@
 #include "dolphinapplication.h"
 #include "dolphinmainwindow.h"
 
-DolphinSettingsDialog& DolphinSettingsDialog::instance(DolphinMainWindow* mainWindow)
-{
-    static DolphinSettingsDialog* instance = 0;
-    if (instance == 0) {
-        instance = new DolphinSettingsDialog(mainWindow);
-    }
-    return *instance;
-}
-
-DolphinSettingsDialog::~DolphinSettingsDialog()
-{
-}
-
-void DolphinSettingsDialog::slotButtonClicked(int button)
-{
-    if (button == Ok || button == Apply) {
-        applySettings();
-    }
-    KPageDialog::slotButtonClicked(button);
-}
-
 DolphinSettingsDialog::DolphinSettingsDialog(DolphinMainWindow* mainWindow) :
     KPageDialog(),
     m_mainWindow(mainWindow)
@@ -68,6 +47,18 @@ DolphinSettingsDialog::DolphinSettingsDialog(DolphinMainWindow* mainWindow) :
     viewSettingsFrame->setIcon(KIcon("view-choose"));
 }
 
+DolphinSettingsDialog::~DolphinSettingsDialog()
+{
+}
+
+void DolphinSettingsDialog::slotButtonClicked(int button)
+{
+    if (button == Ok || button == Apply) {
+        applySettings();
+    }
+    KPageDialog::slotButtonClicked(button);
+}
+
 void DolphinSettingsDialog::applySettings()
 {
     m_generalSettingsPage->applySettings();
diff --git a/src/dolphinsettingsdialog.h b/src/dolphinsettingsdialog.h
index 3a13dd0bd..22d01b02e 100644
--- a/src/dolphinsettingsdialog.h
+++ b/src/dolphinsettingsdialog.h
@@ -39,14 +39,13 @@ class DolphinSettingsDialog : public KPageDialog
     Q_OBJECT
 
 public:
-    static DolphinSettingsDialog& instance(DolphinMainWindow* mainWindow);
+    explicit DolphinSettingsDialog(DolphinMainWindow* mainWindow);
     virtual ~DolphinSettingsDialog();
 
 protected slots:
     virtual void slotButtonClicked(int button);
 
 private:
-    DolphinSettingsDialog(DolphinMainWindow* mainWindow);
     void applySettings();
 
 private: