diff options
| author | Shubham Jangra <[email protected]> | 2018-08-04 16:55:43 -0600 |
|---|---|---|
| committer | Nathaniel Graham <[email protected]> | 2018-08-04 17:02:51 -0600 |
| commit | 6e04f50081a92e5958cbba4c5292a8f5a10f51b4 (patch) | |
| tree | 5516a12018aaebb35a42c12b42e548d3dfb135ee /src | |
| parent | aed8626f860d62ad62583928876c31654ba2283b (diff) | |
Remove custom icon selection for trash
Summary: CCBUG: 391200
Test Plan:
1. Open Dolphin
2. Edit trash in places item
Result: No custom icon option available
Reviewers: ngraham, #dolphin, broulik, pino, elvisangelaccio, cfeck
Reviewed By: ngraham, #dolphin, elvisangelaccio, cfeck
Subscribers: rkflx, cfeck, elvisangelaccio, pino, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D14378
Diffstat (limited to 'src')
| -rw-r--r-- | src/panels/places/placesitemeditdialog.cpp | 22 |
1 files changed, 12 insertions, 10 deletions
diff --git a/src/panels/places/placesitemeditdialog.cpp b/src/panels/places/placesitemeditdialog.cpp index 289b511af..dfb5dda10 100644 --- a/src/panels/places/placesitemeditdialog.cpp +++ b/src/panels/places/placesitemeditdialog.cpp @@ -59,7 +59,7 @@ void PlacesItemEditDialog::setIcon(const QString& icon) QString PlacesItemEditDialog::icon() const { - return m_iconButton->icon(); + return m_iconButton ? m_iconButton->icon() : m_icon; } void PlacesItemEditDialog::setText(const QString& text) @@ -144,15 +144,17 @@ void PlacesItemEditDialog::initialize() m_urlEdit->setMinimumWidth(m_urlEdit->fontMetrics().height() * (40 / 2)); connect(m_urlEdit, &KUrlRequester::textChanged, this, &PlacesItemEditDialog::slotUrlChanged); - m_iconButton = new KIconButton(mainWidget); - formLayout->addRow(i18nc("@label", "Choose an icon:"), m_iconButton); - m_iconButton->setIconSize(IconSize(KIconLoader::Desktop)); - m_iconButton->setIconType(KIconLoader::NoGroup, KIconLoader::Place); - if (m_icon.isEmpty()) { - QMimeDatabase db; - m_iconButton->setIcon(db.mimeTypeForUrl(m_url).iconName()); - } else { - m_iconButton->setIcon(m_icon); + if (m_url.scheme() != QLatin1String("trash")) { + m_iconButton = new KIconButton(mainWidget); + formLayout->addRow(i18nc("@label", "Choose an icon:"), m_iconButton); + m_iconButton->setIconSize(IconSize(KIconLoader::Desktop)); + m_iconButton->setIconType(KIconLoader::NoGroup, KIconLoader::Place); + if (m_icon.isEmpty()) { + QMimeDatabase db; + m_iconButton->setIcon(db.mimeTypeForUrl(m_url).iconName()); + } else { + m_iconButton->setIcon(m_icon); + } } if (m_allowGlobal) { |