diff options
| author | David Hallas <[email protected]> | 2019-10-01 17:24:53 +0200 |
|---|---|---|
| committer | David Hallas <[email protected]> | 2019-10-03 05:40:10 +0200 |
| commit | c71c1c94be2e5ab2e14162a15780d4d12bee307b (patch) | |
| tree | f57dfd9333286b2b51eade773fa5abeb5a0c6552 /src | |
| parent | 43ea7052e15b1cb917bcc6cd2bd3a8046179e45c (diff) | |
Fix missing setDefaultShortcuts call
Summary:
The commit eec49bc38f4e256b66bf16ee5428c5f5d7e97e25 cased a warning to
be emitted when starting Dolphin:
KXMLGUIFactoryPrivate::saveDefaultActionProperties(): Shortcut for action "go_forward" "&Forward" set with QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s) instead.
The fix is to call
actionCollection()->setDefaultShortcuts(m_forwardAction, m_forwardAction->shortcuts());
so that the default shortcuts are setup.
Reviewers: elvisangelaccio
Reviewed By: elvisangelaccio
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D24342
Diffstat (limited to 'src')
| -rw-r--r-- | src/dolphinmainwindow.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp index 83dcd1b18..ce2013798 100644 --- a/src/dolphinmainwindow.cpp +++ b/src/dolphinmainwindow.cpp @@ -1427,6 +1427,8 @@ void DolphinMainWindow::setupActions() connect(m_forwardAction->menu(), &QMenu::aboutToShow, this, &DolphinMainWindow::slotAboutToShowForwardPopupMenu); connect(m_forwardAction->menu(), &QMenu::triggered, this, &DolphinMainWindow::slotGoForward); actionCollection()->addAction(m_forwardAction->objectName(), m_forwardAction); + actionCollection()->setDefaultShortcuts(m_forwardAction, m_forwardAction->shortcuts()); + // enable middle-click to open in a new tab auto *middleClickEventFilter = new MiddleClickActionEventFilter(this); connect(middleClickEventFilter, &MiddleClickActionEventFilter::actionMiddleClicked, this, &DolphinMainWindow::slotBackForwardActionMiddleClicked); |