diff options
| author | Méven Car <[email protected]> | 2026-03-10 11:48:03 +0100 |
|---|---|---|
| committer | Méven Car <[email protected]> | 2026-03-11 09:40:44 +0000 |
| commit | ddfc69105a8e8975a517210116de625c621a6757 (patch) | |
| tree | 258920d21c0157944740ead136fd48fc5de81759 /src | |
| parent | dc1379718bc98e1b9c12ac0aa75278b35edb414a (diff) | |
trashsettingspage: prevent a memleak on exit
KCModuleLoader when passed in a parent Widget will add a layout to it.
The internal widget is added to it.
When we don't pass a parentWidget, this layout leaks.
Instead don't add a layout ourselves, let the one in KCModuleLoader do
the work.
Detected by asan.
Diffstat (limited to 'src')
| -rw-r--r-- | src/settings/trash/trashsettingspage.cpp | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/src/settings/trash/trashsettingspage.cpp b/src/settings/trash/trashsettingspage.cpp index b19571338..7d61a49ce 100644 --- a/src/settings/trash/trashsettingspage.cpp +++ b/src/settings/trash/trashsettingspage.cpp @@ -15,11 +15,7 @@ TrashSettingsPage::TrashSettingsPage(QWidget *parent) : SettingsPageBase(parent) { - QFormLayout *topLayout = new QFormLayout(this); - - m_kcm = KCModuleLoader::loadModule(KPluginMetaData(QStringLiteral("kcm_trash"))); - - topLayout->addRow(m_kcm->widget()); + m_kcm = KCModuleLoader::loadModule(KPluginMetaData(QStringLiteral("kcm_trash")), this); loadSettings(); |
