diff options
| author | Piotr Henryk Dabrowski <[email protected]> | 2020-01-11 16:09:36 +0100 |
|---|---|---|
| committer | Elvis Angelaccio <[email protected]> | 2020-01-11 16:13:08 +0100 |
| commit | f729f6f5b1d1bbc1b4fab2f925f16f2c2c7128d5 (patch) | |
| tree | c4ee743ba5fd2ad3640a4eee3d2db52f9702134a /src | |
| parent | 771f78276d5a720d585917253e25c92ae6640f49 (diff) | |
Hide tooltip instantly on filter change
Summary:
Instantly hide tooltip shown over an element when filter bar changes.
Currently the tooltip stays even when filtering causes the file under the mouse to change or disappears entirely.
The tooltip also continues to cover much of the window - hiding the new filtering results from user.
This is an enhancement to D22512
Test Plan:
1. place the mouse pointer over a file to show the tooltip
2. press "/" to activate filter bar
3. type in filter phrase
Reviewers: #dolphin, elvisangelaccio, ngraham
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D26576
Diffstat (limited to 'src')
| -rw-r--r-- | src/dolphinviewcontainer.cpp | 2 | ||||
| -rw-r--r-- | src/views/dolphinview.h | 10 |
2 files changed, 7 insertions, 5 deletions
diff --git a/src/dolphinviewcontainer.cpp b/src/dolphinviewcontainer.cpp index a7587a91c..9ed7654fa 100644 --- a/src/dolphinviewcontainer.cpp +++ b/src/dolphinviewcontainer.cpp @@ -510,6 +510,7 @@ void DolphinViewContainer::setFilterBarVisible(bool visible) { Q_ASSERT(m_filterBar); if (visible) { + m_view->hideToolTip(ToolTipManager::HideBehavior::Instantly); m_filterBar->show(); m_filterBar->setFocus(); m_filterBar->selectAll(); @@ -659,6 +660,7 @@ void DolphinViewContainer::closeFilterBar() void DolphinViewContainer::setNameFilter(const QString& nameFilter) { + m_view->hideToolTip(ToolTipManager::HideBehavior::Instantly); m_view->setNameFilter(nameFilter); delayedStatusBarUpdate(); } diff --git a/src/views/dolphinview.h b/src/views/dolphinview.h index ba38d3234..538e00e83 100644 --- a/src/views/dolphinview.h +++ b/src/views/dolphinview.h @@ -312,6 +312,11 @@ public: */ static QUrl openItemAsFolderUrl(const KFileItem& item, const bool browseThroughArchives = true); + /** + * Hides tooltip displayed over element. + */ + void hideToolTip(const ToolTipManager::HideBehavior behavior = ToolTipManager::HideBehavior::Later); + public slots: /** * Changes the directory to \a url. If the current directory is equal to @@ -738,11 +743,6 @@ private: void applyModeToView(); /** - * Hides tooltip displayed over element. - */ - void hideToolTip(const ToolTipManager::HideBehavior behavior = ToolTipManager::HideBehavior::Later); - - /** * Helper method for DolphinView::paste() and DolphinView::pasteIntoFolder(). * Pastes the clipboard data into the URL \a url. */ |
