diff options
Diffstat (limited to 'src/panels/terminal')
| -rw-r--r-- | src/panels/terminal/terminalpanel.cpp | 35 | ||||
| -rw-r--r-- | src/panels/terminal/terminalpanel.h | 4 |
2 files changed, 38 insertions, 1 deletions
diff --git a/src/panels/terminal/terminalpanel.cpp b/src/panels/terminal/terminalpanel.cpp index 9d30dcd62..75bfe93d0 100644 --- a/src/panels/terminal/terminalpanel.cpp +++ b/src/panels/terminal/terminalpanel.cpp @@ -6,6 +6,7 @@ #include "terminalpanel.h" +#include <KActionCollection> #include <KIO/DesktopExecParser> #include <KIO/Job> #include <KIO/JobUiDelegate> @@ -17,6 +18,8 @@ #include <KPluginFactory> #include <KProtocolInfo> #include <KShell> +#include <KXMLGUIBuilder> +#include <KXMLGUIFactory> #include <kde_terminal_interface.h> #include <QAction> @@ -100,6 +103,21 @@ QString TerminalPanel::runningProgramName() const return m_terminal ? m_terminal->foregroundProcessName() : QString(); } +KActionCollection *TerminalPanel::actionCollection() +{ + // m_terminal is the only reference reset to nullptr in case the terminal is + // closed again + if (m_terminal && m_konsolePart && m_terminalWidget) { + const auto guiClients = m_konsolePart->childClients(); + for (auto *client : guiClients) { + if (client->actionCollection()->associatedWidgets().contains(m_terminalWidget)) { + return client->actionCollection(); + } + } + } + return nullptr; +} + bool TerminalPanel::hasProgramRunning() const { return m_terminal && (m_terminal->foregroundProcessId() != -1); @@ -139,6 +157,23 @@ void TerminalPanel::showEvent(QShowEvent* event) m_layout->removeWidget(m_konsolePartMissingMessage); } m_terminal = qobject_cast<TerminalInterface*>(m_konsolePart); + + // needed to collect the correct KonsolePart actionCollection + // namely the one of the single inner terminal and not the outer KonsolePart + if (!m_konsolePart->factory() && m_terminalWidget) { + if (!m_konsolePart->clientBuilder()) { + m_konsolePart->setClientBuilder(new KXMLGUIBuilder(m_terminalWidget)); + } + + auto factory = new KXMLGUIFactory(m_konsolePart->clientBuilder(), this); + factory->addClient(m_konsolePart); + + // Prevents the KXMLGui warning about removing the client + connect(m_terminalWidget, &QObject::destroyed, this, [factory, this] { + factory->removeClient(m_konsolePart); + }); + } + } else if (!m_konsolePartMissingMessage) { const auto konsoleInstallUrl = QUrl("appstream://org.kde.konsole.desktop"); const auto konsoleNotInstalledText = i18n("Terminal cannot be shown because Konsole is not installed. " diff --git a/src/panels/terminal/terminalpanel.h b/src/panels/terminal/terminalpanel.h index dc6605da6..5a2b0bb83 100644 --- a/src/panels/terminal/terminalpanel.h +++ b/src/panels/terminal/terminalpanel.h @@ -7,12 +7,13 @@ #ifndef TERMINALPANEL_H #define TERMINALPANEL_H -#include "panels/panel.h" #include "kiofuse_interface.h" +#include "panels/panel.h" #include <QQueue> class TerminalInterface; +class KActionCollection; class KMessageWidget; class QVBoxLayout; class QWidget; @@ -47,6 +48,7 @@ public: bool terminalHasFocus() const; bool hasProgramRunning() const; QString runningProgramName() const; + KActionCollection *actionCollection(); public Q_SLOTS: void terminalExited(); |
