┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
Diffstat (limited to 'src')
-rw-r--r--src/dolphincontextmenu.cpp1
-rw-r--r--src/dolphinmainwindow.cpp1
-rw-r--r--src/kitemviews/kfileitemmodel.cpp4
-rw-r--r--src/kitemviews/kitemlistcontroller.cpp3
-rw-r--r--src/panels/information/phononwidget.cpp2
5 files changed, 4 insertions, 7 deletions
diff --git a/src/dolphincontextmenu.cpp b/src/dolphincontextmenu.cpp
index 94c1d7ce8..c35f442cb 100644
--- a/src/dolphincontextmenu.cpp
+++ b/src/dolphincontextmenu.cpp
@@ -428,6 +428,7 @@ void DolphinContextMenu::addShowMenuBarAction()
bool DolphinContextMenu::placeExists(const QUrl& url) const
{
+ Q_UNUSED(url)
// Creating up a PlacesItemModel to find out if 'url' is one of the Places
// can be expensive because the model asks Solid for the devices which are
// available, which can take some time.
diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp
index 762e21f94..87f974fc1 100644
--- a/src/dolphinmainwindow.cpp
+++ b/src/dolphinmainwindow.cpp
@@ -410,6 +410,7 @@ void DolphinMainWindow::closeEvent(QCloseEvent* event)
case QDialogButtonBox::No:
// Close only the current tab
m_tabWidget->closeTab();
+ Q_FALLTHROUGH();
default:
event->ignore();
return;
diff --git a/src/kitemviews/kfileitemmodel.cpp b/src/kitemviews/kfileitemmodel.cpp
index d4f356125..b6a001642 100644
--- a/src/kitemviews/kfileitemmodel.cpp
+++ b/src/kitemviews/kfileitemmodel.cpp
@@ -246,7 +246,6 @@ QMimeData* KFileItemModel::createMimeData(const KItemSet& indexes) const
// Copyright (C) 2006 David Faure <[email protected]>
QList<QUrl> urls;
QList<QUrl> mostLocalUrls;
- bool canUseMostLocalUrls = true;
const ItemData* lastAddedItem = nullptr;
for (int index : indexes) {
@@ -269,9 +268,6 @@ QMimeData* KFileItemModel::createMimeData(const KItemSet& indexes) const
bool isLocal;
mostLocalUrls << item.mostLocalUrl(isLocal);
- if (!isLocal) {
- canUseMostLocalUrls = false;
- }
}
}
diff --git a/src/kitemviews/kitemlistcontroller.cpp b/src/kitemviews/kitemlistcontroller.cpp
index 672c31ae4..bde2bb26c 100644
--- a/src/kitemviews/kitemlistcontroller.cpp
+++ b/src/kitemviews/kitemlistcontroller.cpp
@@ -433,8 +433,7 @@ bool KItemListController::keyPressEvent(QKeyEvent* event)
}
}
}
- // Fall through to the default case and add the Space to the current search string.
-
+ Q_FALLTHROUGH(); // fall through to the default case and add the Space to the current search string.
default:
m_keyboardManager->addKeys(event->text());
// Make sure unconsumed events get propagated up the chain. #302329
diff --git a/src/panels/information/phononwidget.cpp b/src/panels/information/phononwidget.cpp
index fed6b0ee2..494429b8c 100644
--- a/src/panels/information/phononwidget.cpp
+++ b/src/panels/information/phononwidget.cpp
@@ -167,7 +167,7 @@ void PhononWidget::stateChanged(Phonon::State newstate)
m_videoPlayer->hide();
}
emit hasVideoChanged(false);
- // fall through
+ Q_FALLTHROUGH();
default:
m_stopButton->hide();
m_playButton->show();