┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/filterbar/filterbar.cpp
AgeCommit message (Collapse)Author
2026-01-22clang-tidy: use default for trivial constructorMéven Car
2024-03-13Animate most of the barsFelix Ernst
When a bar is toggled visible this usually happens because the user might want to use its functionality now. However, if bars appear without animation or at a location the user is not currently looking at, they might not notice that they have appeared at all. An animation makes it more likely that the user notices the change and can then use the newly made visible component. Another reason for animations for showing or hiding of components is that it can be disorienting for users when panels or bars suddenly appear or disappear without animation. There is no visible movement then, so the user might not know what happened if they didn't concentrate or blink at that moment. The newly appearing or disappearing component might also displace other components which can make it difficult to find what one was just looking at. These bars animate now after this change: - Search panel - Filter bar - Status bar This is implemented by extracting the animation code from SelectionMode::TopBar into a new abstract base class AnimatedHeightWidget. This class is now also used in SelectionMode::BottomBar and the animating code there was removed. These bars are left in Dolphin that stay without animation: - Menu bar (Would probably need to be implemented in KXmlGui) - Tool bar (Would probably need to be implemented in KXmlGui) - Tab bar (Needs a different appraoch because it already inherits QTabBar and therefore can not inherit AnimatedHeightWidget)
2023-07-05Add explicit moc includes to sources for moc-covered headersFriedrich W. H. Kossebau
* speeds up incremental builds as changes to a header will not always need the full mocs_compilation.cpp for all the target's headers rebuild, while having a moc file sourced into a source file only adds minor extra costs, due to small own code and the used headers usually already covered by the source file, being for the same class/struct * seems to not slow down clean builds, due to empty mocs_compilation.cpp resulting in those quickly processed, while the minor extra cost of the sourced moc files does not outweigh that in summary. Measured times actually improved by some percent points. (ideally CMake would just skip empty mocs_compilation.cpp & its object file one day) * enables compiler to see all methods of a class in same compilation unit to do some sanity checks * potentially more inlining in general, due to more in the compilation unit * allows to keep using more forward declarations in the header, as with the moc code being sourced into the cpp file there definitions can be ensured and often are already for the needs of the normal class methods
2023-06-29Use ellipsis everywhere instead of three dotsTem PQD
Better for screen readers etc.
2023-04-22FilterBar: improve keyboard behavior and tab orderingEugene Popov
With this MR, when the filterbar has the keyboard focus: - pressing the Tab key moves the keyboard focus to the view - pressing the Down, PageDown, Up and PageUp keys moves the focus to the view and emulate pressing the same key in it (you can navigate directly from the filterbar)
2023-02-05Add clang-format and format code as in FrameworksSerg Podtynnyi
2023-01-25Clear filter bar on clicking current folder in placesSerg Podtynnyi
Reset the filter bar when user clicks on the current folder in places list, also rename slot function to be more clear. BUG: 259382
2022-09-26Remove unused includesLaurent Montel
2020-10-23Compile with QT_NO_KEYWORDSAlexander Lohnau
2020-08-25Output of licensedigger + manual cleanup afterwards.Elvis Angelaccio
Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files.
2020-05-18Move search and filter bar close buttons to the rightNate Graham
Summary: Close buttons for windows, tabs, and pretty much everything else in KDE are on the right, not the left. This patch makes Dolphin's search and filter bars follow that. BUG: 421372 FIXED-IN: 20.08.0 Test Plan: {F8314176} Reviewers: abetts, #dolphin, #vdg, elvisangelaccio, GB_2 Reviewed By: #dolphin, #vdg, elvisangelaccio, GB_2 Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29693
2019-05-25When filter bar is focused, switch to view when tab key is pressedNate Graham
Summary: Various people have requested that the tab key move keyboard focus from the filter bar's text edit field to the main view. It already does this when the Enter and return keys are pressed, but apparently this is not very intuitive and people expect Tab to work too. This patch makes that behavior possible by moving the Lock button to the left of the text edit field, and re-arranging the code so that the filter bar is initialized first. This works because Qt assigns tab ordering by default according to the order of widget construction. So if we simply construct the main view right after the filter bar, then the tab ordering is set up this way automatically. BUG: 403379 BUG: 403356 FIXED-IN: 19.08.0 Test Plan: 1. Activate Filter bar 2. Hit Tab key 3. View has become focused 4. Play around in Dolphin for a while and notice no regressions or crashes Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21177
2019-04-22Use placeholder for search actionCarl Schwan
Summary: See https://hig.kde.org/style/writing/placeholder.html Screenshot: Old: {F6691712} New: {F6698685} Test Plan: Compile and run Reviewers: #dolphin, #vdg, ngraham, elvisangelaccio Reviewed By: #dolphin, #vdg, ngraham Subscribers: GB_2, kde-doc-english, elvisangelaccio, ngraham, yurchor, kfm-devel Tags: #dolphin, #documentation Maniphest Tasks: T10258 Differential Revision: https://phabricator.kde.org/D19770
2019-02-27remove deprecated methodsLaurent Montel
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-03Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2016-03-16[CLAZY] Fixed all level 1 and level 2 warnings with small exceptionsArtur Puzio
REVIEW: 126771
2014-11-10KLineEdit to QLineEditEmmanuel Pescosta
2014-10-18Fix includesMontel Laurent
2014-10-10Clean includes + port to QMenuMontel Laurent
2014-09-12Ported KIcon to QIconEmmanuel Pescosta
REVIEW: 120159
2014-06-29Remove the automoc noiseChristophe Giboudeaux
2014-05-05dolphin: convert panels/ and filterbar to qt signal/slot syntaxAlex Richardson
TerminalPanel connections to konsole part were not converted since there is no header available that defines these function, we have to keep the old syntax here. Additionally the new syntax no longer accepts QPointer arguments, we have to explicitly call .data() there.
2013-06-26Improve filterbar lock button.Kai Uwe Broulik
Use object-(un)locked icon and make it flat. REVIEW: 111233
2013-05-22Filter bar: add a button that prevents clearing if the URL changesStuart Citrin
FEATURE: 256651 FIXED-IN: 4.11.0 REVIEW: 107392
2013-02-19Return the focus from the filter bar to the view if Enter is pressedJens Rutschmann
BUG: 297140 FIXED-IN: 4.11.0 REVIEW: 109020
2011-07-31normalize signals/slotsMontel Laurent
2011-02-04Use capitalized KDE includesPeter Penz
2011-01-22SVN_SILENT: Coding style updatesPeter Penz
svn path=/trunk/KDE/kdebase/apps/; revision=1216293
2010-12-19Select the whole text in the filterbar and searchbox if the widget has lost ↵Peter Penz
the focus and gets focused again by the shortcut (this behavior is consistent to e.g. the behavior in Kate). CCBUG: 256160 svn path=/trunk/KDE/kdebase/apps/; revision=1207719
2010-11-07Make the filter-behavior similar to applications like Kate, where activating ↵Peter Penz
the filter lets focus it again. BUG: 256160 FIXED-IN: 4.6.0 svn path=/trunk/KDE/kdebase/apps/; revision=1193912
2010-07-24Sourcecode hierarchy cleanup: Create folder "views" and move view related ↵Peter Penz
sources to it svn path=/trunk/KDE/kdebase/apps/; revision=1154146
generated by cgit v1.3 (git 2.53.0) at 2026-04-18 09:15:31 +0000