┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/kitemviews/kitemlistwidget.cpp
AgeCommit message (Collapse)Author
2018-12-03KItemListWidget: Use initStyleOptionAnton Kreuzkamp
Instead of using QStyleOption::initFrom, let's use QGraphicsWidget::initStyleOption, which is made for exactly the purpose of KItemListWidget. This is especially important since, according to the docs of QGraphicsItem::paint "The widget argument is optional. [...] For cached painting, widget is always 0.". Even though currently no code in dolphin does cached painting, for the sake of modularity one should not rely on widget to be non-null. Using QStyleOption::initFrom does assume that, though. In fact, GammaRay asks the items to do cached painting when attaching it to the application, causing it to crash.
2018-03-29[KItemListView] Check if KItemListStyleOption actually changed before ↵Kai Uwe Broulik
emitting a change This avoids work being done when it doesn't need to be. For instance, the preview generator waits for everything to have settled using a 200ms timer before generating a preview. This timer fired also in response to onStyleOptionChanged and needlessly delayed preview generation when navigating between folders despite the style option (e.g. icon size, view mode) not having changed. Differential Revision: https://phabricator.kde.org/D11481
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-03Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2017-11-21Modernize: Use nullptr everywhereKevin Funk
2016-11-21Call columnWidthChanged with actual previous widthDon Nguyen
REVIEW: 129334
2016-08-06Fix some low-hanging warning fruitsMartin T. H. Sandsmark
2015-03-25squash me with a some other commit in kitemlistwidgetinformantDavid Edmundson
2015-03-25Create drag pixmaps which match the device pixel ratioDavid Edmundson
2015-02-06Fix includesMontel Laurent
2015-01-30Port away from KGlobalSettings::graphicEffectsLevel()Emmanuel Pescosta
REVIEW: 122309
2015-01-28Merge branch 'Applications/14.12' into frameworksEmmanuel Pescosta
Conflicts: dolphin/src/main.cpp kdepasswd/kcm/kcm_useraccount.desktop konqueror/settings/ebrowsing/ebrowsing.desktop konqueror/settings/kio/cache.desktop konqueror/settings/kio/cookies.desktop konqueror/settings/kio/netpref.desktop konqueror/settings/kio/proxy.desktop konqueror/settings/kio/smb.desktop konqueror/settings/kio/uasproviders/firefox30oncurrent.desktop konqueror/settings/kio/uasproviders/ie90onwinnt71.desktop konqueror/settings/kio/useragent.desktop lib/konq/konq_operations.cpp
2014-11-09Make sure that m_selectionToggle is not 0 before calling deleteLater()Frank Reininghaus
Commit 1938ad54d4ee640f04d24bad3b690095bc9b8668 replaced delete by deleteLater(). However, the latter cannot be used safely with null pointers. This commit adds a safety check in order to make sure that we do not get a crash. Thanks to Christoph Feck for pointing out this issue.
2014-11-09Use deleteLater() to delete the selection toggle in KItemListWidgetFrank Reininghaus
This patch should make a crash with a backtrace as provided in the bug report impossible. I'm not sure if this would really prevent the crash - it looks like the actual cause of the problem could be in QGraphicsView or anywhere else, but it's hard to tell because the bug was reported just once and does not seem reproducible. But I'm pretty sure that this change doesn't make anything worse. BUG: 334785 REVIEW: 121087
2014-10-27Port to QDebug*. KVBox--Montel Laurent
2014-07-04Merge branch 'master' into frameworksLuca Beltrame
2014-07-04Improve drawing selected items in Compact/Details View and Places PanelFrank Reininghaus
This commit removes the icon tinting for the selected item in Compact and Details View, and extends the selection rectangle such that it includes the icon area as well. The icon tinting can be disturbing, and having a selection rectangle that only includes the text can look a bit strange, especially in the Places Panel. BUG: 304643 REVIEW: 119018 FIXED-IN: 4.14.0
2014-06-29Remove the automoc noiseChristophe Giboudeaux
2014-06-01Merge remote-tracking branch 'origin/master' into frameworksFrank Reininghaus
Conflicts: lib/konq/konq_operations.cpp
2014-05-29Use "selectionToggleRect().contains(pos)" insteadEmmanuel Pescosta
of "m_selectionToggle->contains(pos)" in KItemListWidget::setHoverPosition(const QPointF& pos). This wrong check was accidentally introduced by commit 24326d447358f0dbfc18963743207d4a3d4f1c9e BUG: 299328 REVIEW: 118320 FIXED-IN: 4.13.2
2014-05-13Merge remote-tracking branch 'origin/master' into frameworksFrank Reininghaus
Since the master branch had never been merged into frameworks since the creation of the frameworks branch, I had to fix a couple of merge conflicts and make another change in order to make it build - I hope I did not get anything wrong. We should probably merge master into frameworks on a regular basis from now on. CCMAIL:[email protected] Conflicts: dolphin/src/dolphinmainwindow.cpp dolphin/src/search/dolphinfacetswidget.cpp dolphin/src/statusbar/dolphinstatusbar.cpp dolphin/src/views/dolphinview.cpp
2014-05-05dolphin: convert kitemviews/ to qt5 signal slot syntaxAlex Richardson
This conversion was performed automatically using convert2qt5signalslot. The only manual changes required were changing the overloaded signal KDirLister::redirection and KDirLister::completed from KUrl to QUrl. All other cases were no problem since these signals are not overloaded and a static_cast for disambiguation is not necessary. Code inside HAVE_BALOO is not converted yet, will do that once I can build a version with Baloo.
2014-03-03Add a hover effect for the selection toggle.Emmanuel Pescosta
FIXED-IN: 4.13.0 REVIEW: 116028 BUG: 299328
2013-08-24Adjust the size and position of the selection toggle on iconEmmanuel Pescosta
resize (when changing the zoomlevel). BUG: 310412 REVIEW: 112250 FIXED-IN: 4.11.1
2012-06-12Drag pixmap: Turn off the hover-statePeter Penz
2012-06-12Drag-pixmap fixesPeter Penz
- Don't use the selection-tinted icon when dragging a single item - Decrease the vertical gap for the hotspot - Prevent drawing tree-lines when dragging items for the Places Panel CCBUG: 301624
2012-05-18Enable basic drag and drop support for the Places PanelPeter Penz
The dropping has not been implemented yet, however in the context of this step the creating of the drag-pixmap is now forwarded to the item-widgets. This allows creating some optimized dragging-pixmaps e.g. for the details-view, where only the name and icon should be provided as drag-pixmap.
2012-04-21Prepare view-engine for non-KFileItem usecasePeter Penz
Up to now the view-engine only provided a model-implementation that supports file-items. The view-engine always had been designed to be able to work with any kind of model, so now a KStandardItemModel is available. The plan is to convert the places panel to the new view-engine. It should be no problem to fix this until the feature freeze - in the worst case the places-panel code could be reverted while still keeping the KStandardItemModel changes.
2012-04-17Implement inline-renaming for the new view-enginePeter Penz
BUG: 286893 FIXED-IN: 4.9.0
2012-04-11KItemViews: Internal directory restructurationPeter Penz
- Move all private headers from the kitemviews-directory into the 'private' subdirectory. - Get rid of DolphinDirLister and just use a directory-lister internally in KFileItemModel. - Minor interface-cleanups for signals
2012-04-02Minor internal cleanupPeter Penz
2012-04-02Fix focus-rectangle issuesPeter Penz
Assure that the focus-rectangle exactly matches to the bottom of the rendered text. BUG: 297203 BUG: 289804 FIXED-IN: 4.9.0
2012-03-23Details view: Optionally remember user changed column-widthsPeter Penz
If the user changed a column-width in the details-view, up to now the width got reset when changing a directory or when restarting Dolphin. Now the column-widths automatically get remembered for each directory in case if the user has modified the width. The automatic resizing is still turn on per default. The storing of the custom column-width can easily be reset by right clicking on the header and selecting "Automatic Column Widths" from the context-menu. Some finetuning is still necessary (e.g. the "Adjust View Properties" dialog currently is not aware about this setting) but this will be fixed during the next weeks. BUG: 264434 FIXED-IN: 4.9.0
2012-02-23Whitespace cleanups and documentation fixesPeter Penz
2012-02-22Fix alternate backgrounds when enabling groupingPeter Penz
Up to now the alternating backgrounds just have been calculated by checking whether the item index is odd. This does not work well when grouping is enabled: In this case the alternate background color of the first item of a group should stay consistent.
2012-02-14Details view: Siblings fixesPeter Penz
The siblings should only range within one group.
2012-02-14Details view: Fix indicator-branchesPeter Penz
Up to now no indicator-branches have been drawn when showing a tree. The patch fixes this so that that the style-dependent branches are drawn. The main part of the patch is the implementation of KItemListView::updateSiblingsInformation(). Most of the other changes are related due to an internal renaming of the expansionsLevel-role to expandedParentsCount and some related cleanups. BUG: 290276 FIXED-IN: 4.8.1
2012-02-11Group header layout fixesPeter Penz
- Don't use a margin for the first group header - Provide margins between the groups - Use a more subtle coloring - Prevent animation glitches when resizing a window
2012-02-04Icons view: Layout optimizationsPeter Penz
- Assure that landscape-previews use the whole available width of the icon-area instead of only using the square width. This waste of space occured if the text-width was larger than the icon-width. - Only use one margin instead of two between the icons and the text to improve the visual appearance (thanks to Martin Zilz for the hint) BUG: 293268 FIXED-IN: 4.8.1 CCMAIL: [email protected]
2012-01-17Disable smooth-scrolling dependent on the graphics-effect levelPeter Penz
If the graphics-effect-level has been set to NoEffects (systemsettings -> Appearance -> Style -> Fine Tuning), the smooth scrolling in Dolphin will be disabled. Additionally the duration for the smooth-scrolling has been decreased from 200 ms to 100 ms to reduce the lag. A wrong calculation of the end-value has been fixed that might trigger a wrong position of the content. BUG: 291740 BUG: 291607 FIXED-IN: 4.8.0
2012-01-14Fix current-item indicator in combination with the cleanlooks stylePeter Penz
Thanks to Christoph Feck for the hint. BUG: 290536 FIXED-IN: 4.8.0
2012-01-05Fix style-issues in items when not using OxygenPeter Penz
Thanks to Jonathan Marten and Christoph Feck for the analyses and the patch. Still open: The focus frame in cleanlooks is not drawn. CCBUG: 290536
2011-12-07Fix icon boundaries issuePeter Penz
The size of the icon boundaries should be as minimal as possible. The patch for fixing the zooming-issues with the selection resulted into a minor regression where the icon boundaries might be too large. This patch remembers the original size of the pixmap to be able to scale m_iconRect.
2011-12-06Selection and current item fixesPeter Penz
- Remember selection + current item when switching view-modes - Fix the current item indicator alignment for selections - Set the item as current item when the selection toggle has been clicked
2011-11-18Apply the selected-state to the current itemPeter Penz
This assures that (with the default colors) the indication of the current item is done in white instead of black.
2011-11-18Fix colors for the selection/hover-areaPeter Penz
Thanks to Hugo Pereira Da Costa for pointing this out and the initial patch! CCMAIL: [email protected]
2011-11-13Fix selection style issuesPeter Penz
Don't use a custom drawing code for showing the hover-indication or selection of the text. - The default style for items is used. - Merge icon-rectangle and text-rectangle if possible. - Fix background and minor focus-issues
2011-11-13Bring back the selection-markersPeter Penz
Still some finetuning is necessary, but lets first bring back the missing features from Dolphin 1.x to 2.0 before starting with this.
2011-10-23Improve group-header layoutPeter Penz
- Apply a dynamic width - Use a height that depends on the style - Cleanup some interfaces and replace xxxBoundingRect() by xxxRect()
2011-10-10Remove workaround to draw the focus indicator manuallyPeter Penz
In Oxygen the focus-indicator has only been drawn for widget instances derived from QAbstractItemView and Q3ListView, so it was not possible in Dolphin to use the style for drawing. This has been fixed now in Oxygen, so using the style works now. The custom code for drawing the text background will be removed and replaced by a style-code later. CCMAIL: [email protected]
generated by cgit v1.3 (git 2.53.0) at 2026-04-21 05:06:44 +0000