| Age | Commit message (Collapse) | Author |
|
For now this just includes the settings for the information panel.
Prior to this commit the options for configuring the information panel
were only exposed via right clicking the information panel. This was
not discoverable enough. Our guidelines also state that much. See:
https://community.kde.org/Get_Involved/Design/Frequently_Discussed_Topics#Context_menus_are_not_enough
The settings page is missing the "Configure" button for the entries in
the information panel, which can only be found in the context menu.
This is because I thought it would be weird to move it to the settings
page. (The "configure" button is used to select the entries for the
information panel)
BUG: 480243
FIXED-IN: 24.05
|
|
|
|
|
|
|
|
|
|
* speeds up incremental builds as changes to a header will not always
need the full mocs_compilation.cpp for all the target's headers rebuild,
while having a moc file sourced into a source file only adds minor
extra costs, due to small own code and the used headers usually
already covered by the source file, being for the same class/struct
* seems to not slow down clean builds, due to empty mocs_compilation.cpp
resulting in those quickly processed, while the minor extra cost of the
sourced moc files does not outweigh that in summary.
Measured times actually improved by some percent points.
(ideally CMake would just skip empty mocs_compilation.cpp & its object
file one day)
* enables compiler to see all methods of a class in same compilation unit
to do some sanity checks
* potentially more inlining in general, due to more in the compilation unit
* allows to keep using more forward declarations in the header, as with the
moc code being sourced into the cpp file there definitions can be ensured
and often are already for the needs of the normal class methods
|
|
Better for screen readers etc.
|
|
|
|
|
|
BUG: 364956
BUG: 453211
|
|
|
|
|
|
Refactor and simplify things along the way.
BUG: 457813
|
|
|
|
|
|
|
|
|
|
With this change (plus https://invent.kde.org/frameworks/kio/-/merge_requests/702), slow files will be treated as remote files for generating previews. This should make browsing local mounts of remote locations smoother.
|
|
|
|
BUG: 401170
|
|
|
|
BUG: 430095
BUG: 412902
FIXED-IN: 21.08
|
|
BUG: 434329
FIXED-IN: 21.04
|
|
|
|
|
|
|
|
|
|
|
|
As recommended, we now set `easingCurve` directly.
|
|
With this patch dolphin now supports the following touch gestures:
* Tap gesture to interact/open with directories, files and so on
* TapAndHold and release gesture for access to the context menu (main window, panel folder, places and information)
* TapAndHold and moving gesture for drag and drop action (main windows, panel folder and places)
* pinch gesture for zoom in main window
* kinetic scrolling (QScroller) for main window, panel folder, panel places, panel information, setting preview and service
* two fingers swipe gesture to left, right and up as shortcut to navigate back, forward and up
* two finger tap gesture to toggle item selection, similar to Ctrl and left mouse click
FEATURE: 385066
FIXED-IN: 20.11.80
You are currently rebasing branch 'touch' on '85241a924'.
|
|
Unfortunately licensedigger does not strip the trailing * characters.
While at it, use a common style for all source files.
|
|
This allows to extend the functionality to non-local files and avoids a warning
on such files (`QFSFileEngine::open: No file name specified`)
|
|
Summary:
Folders previews can be long to generate.
This can be noticeable by the user.
This diff displays folder icons after a 100ms timer.
BUG: 420340
FIXED-IN: 20.08
Test Plan:
rm -r ~/.cache/thumbnails/
In dolphin open trash
Click on download (or any directory with a long to generate preview).
Reviewers: #dolphin, ngraham
Reviewed By: #dolphin, ngraham
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D29204
|
|
Summary: BUG: 420512
Test Plan:
Select on hove over a video file
Type Ctrl + F
Type some test + enter
Reviewers: ngraham, #dolphin, elvisangelaccio
Reviewed By: ngraham, #dolphin
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D29158
|
|
Summary: Similar to D29158
Test Plan:
Select a video file
Type CTRL + F and some text
Hit ALt + left or previous button
Before:
The video controls are not visible for selected video file
After:
Video controls are visible again.
Reviewers: ngraham, elvisangelaccio, #dolphin
Reviewed By: ngraham, #dolphin
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D29160
|
|
Summary:
Make icons match the preview size.
It prevents a user that had a wide information panel,
seeing a size difference between a preview and an icon despite they can look similar (i.e folder preview).
Test Plan:
Before:
{F8248373, size=full}
After:
{F8248370, size=full}
Reviewers: #dolphin, ngraham, elvisangelaccio
Reviewed By: #dolphin, ngraham, elvisangelaccio
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D29002
|
|
Summary: Needed after D28901 to ensure we get the UDS_RECURSIVE_SIZE out of the stat calls.
Test Plan: Trash size is visible in status bar and information panel again.
Reviewers: ngraham, dfaure, #dolphin
Reviewed By: dfaure
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D28950
|
|
|
|
Summary: `IconSize()` method is deprecated from Frameworks 5.66
Reviewers: #dolphin, elvisangelaccio, meven
Reviewed By: #dolphin, elvisangelaccio
Subscribers: kfm-devel
Tags: #dolphin
Maniphest Tasks: T11637
Differential Revision: https://phabricator.kde.org/D26237
|
|
Summary: CCBUG: 392882
Test Plan:
1. Create a file
2. Remove it, so that it goes to the trash
3. Open trash
4. Empty trash
Before:
Information panel icon is still user-trash-full
After:
Information panel icon is changed to user-trash
Reviewers: ngraham, #dolphin, elvisangelaccio
Reviewed By: ngraham, #dolphin, elvisangelaccio
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D23668
|
|
|
|
Summary:
Adds the capability to view animated images on the preview in the information panel.
This was a request from a user back in 2009 (https://bugs.kde.org/show_bug.cgi?id=182257), but I think nowadays with stickers/memes and what not, it's even more useful.
It keeps the size default transition of the preview viewer before starting the animation, so that the visual integration is smoother.
{F7289110}
FEATURE: 182257
FIXED-IN: 19.11.80
Test Plan: Open the information panel and hover over some animated images (gif/webp/mng)
Reviewers: #dolphin, #vdg, ngraham, elvisangelaccio
Reviewed By: #vdg, ngraham
Subscribers: pino, fuksitter, meven, broulik, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D23538
|
|
GIT_SILENT
|
|
|
|
Summary:
Stop is not as useful as paused plus it makes the button coherent with the click to play/pause feature.
CCBUG: 364957
Test Plan: {F7305382}
Reviewers: #dolphin, elvisangelaccio, ngraham
Reviewed By: #dolphin, ngraham
Subscribers: ngraham, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D23648
|
|
Test Plan:
In dolphin, click on a video or audio preview in the information panel.
The video or audio preview starts
Reviewers: elvisangelaccio, #dolphin, ngraham
Reviewed By: elvisangelaccio, #dolphin, ngraham
Subscribers: alexde, anthonyfieroni, ngraham, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D22183
|
|
Summary: e6c1b97d67f6b6c6d4ad935db14241b041b3fca4 introduced a regression preventing previews to be properly resized.
Test Plan: Manual : resizing the information panel and the window
Reviewers: #dolphin, ngraham
Reviewed By: #dolphin, ngraham
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D22473
|
|
play/pause videos or audio
Summary:
It is based on D19844.
I did my best to avoid glitches hence the amount of code touched.
Retry after @pekkah D7539
Moved the setting to the information panel context menu, no more timer
Settings screenshot :
{F6700220}
This would mach the same feature in the open/save dialog (although not equivalent)
{F6696456}
FEATURE: 378613
FIXED-IN: 19.08.0
GUI: New information panel context menu option
Test Plan:
Without auto play
- in dolphin with the information panel opened, and the auto media play feature is disabled (right on the information panel)
- hover over media files
- the behavior is the same as before the patch
With auto play
- in dolphin with the information panel opened, and the auto media play feature is enabled
- hover over media files
- media is played automatically
- hover over another media file, the new media is previewed
Use audio or video file as media.
Reviewers: #dolphin, elvisangelaccio, ngraham
Reviewed By: #dolphin, elvisangelaccio, ngraham
Subscribers: ngraham, broulik, kfm-devel, pekkah
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D19782
|
|
GIT_SILENT
|
|
|