| Age | Commit message (Collapse) | Author |
|---|
|
BUG: 510829
|
|
media file is selected
To reproduce the crash:
- Open Dolphin, disable information panel and close Dolphin
- Re-open Dolphin
- Select a video file
- Enable information panel
- Crash
Problem is that some elements of the MediaWidget panel are created when the widget is shown, in `showEvent` (`m_seekSlider` and `m_topLayout`), and these elements are called before being created.
This MR fixes 2 different crashes:
- Crash creating panel when a video file is selected (call to `m_seekSlider` before its creation)
- Crash creating panel when a video file is selected and autoplay enabled (call to `m_topLayout` before its creation)
|
|
The original implementation prioritized mouse hover over keyboard selection,
preventing panel updates when navigating with arrow keys while the mouse
was over another item.
This patch adds explicit state tracking to ensure keyboard selections
always update the panel, regardless of mouse position.
BUG: 474507
|
|
The information panel does a scaling animation when switching between files. It does not completely make sense because the pixmap passes immediately to the new one, it just animates the scale between the two which just looks glitchy. the effect is particularly visible when switching between a normal folder and one that has thumbnails overlayed on top: the two folder icons appear the same size, but still a weird animation occurs when going from one to another.
Also, the rest of the text of the information panel does change immediately. ideally perhaps some sort of fading animation could make sense, but only if everything in that panel faded together, only the icon fading with the text that is already the "new" one doesn't make much sense
BUG:503036
|
|
When switching files quickly in the Information Panel, the preview pixmap could appear progressively brighter/whiter. This happened because markOutdatedPreview() was applying KIconEffect::toDisabled() multiple times on the same pixmap while a preview job was still pending.
This patch fixes the issue by:
- Tracking the URL that was last disabled, and only applying the disabled effect once per URL.
- Clearing the disabled state whenever a new preview job starts or when a new pixmap is shown.
With this change, the "disabled preview" effect is preserved (still useful for slow HDD or network filesystems), but the progressive white-out artifact no longer occurs when navigating rapidly.
BUG: 507844
|
|
|
|
copied text
QLabel does not support line wrapping at arbitrary positions. The original code achieved word wrap by manually adding newline characters to the text, which resulted in these newlines being included when the filename was selected and copied.
This patch replaces QLabel with QTextEdit for filename display, leveraging QTextEdit's built-in word wrap functionality that handles line breaks purely for display without modifying the underlying text. This ensures copied filenames remain free of unintended newlines.
BUG: 493279
|
|
If the image size is larger than the available size, we need to scale
so it fits into the preview
|
|
|
|
|
|
|
|
Co-authored-by: Felix Ernst <[email protected]>
|
|
will not be there if we have no dbus enabled for kio
|
|
|
|
Now all overlays icons in kitemviews are added in
KStandardItemListWidget::updatePixmapCache.
data[iconOverlays] now contains icon names.
DolphinFileItemListWidget::refreshCache is the sole responsible of
setting the overlays either coming from KFileItemModelRolesUpdater or
KVersionControlPlugin.
This garantees consistency in rendering.
BUG: 497372
|
|
And show them in their actual pixel density.
|
|
That were introduced in:
a55c467fbb31d822d89722812388425327830377
38ab14c87a945153e683657483fa4bcf44d6b0fb
|
|
Instead of the pixmap size that won't be accurate.
It allow KGuiAddons::addOverlays to draw larger images to add overlays.
Consequently the emblems are not longer dependant scaled based on the pixmap aspect
ratio.
BUG: 498211
|
|
Also use dpr for icons.
Amends cebcf8db
BUG: 497576
|
|
The latter is what most other projects use
|
|
|
|
For now this just includes the settings for the information panel.
Prior to this commit the options for configuring the information panel
were only exposed via right clicking the information panel. This was
not discoverable enough. Our guidelines also state that much. See:
https://community.kde.org/Get_Involved/Design/Frequently_Discussed_Topics#Context_menus_are_not_enough
The settings page is missing the "Configure" button for the entries in
the information panel, which can only be found in the context menu.
This is because I thought it would be weird to move it to the settings
page. (The "configure" button is used to select the entries for the
information panel)
BUG: 480243
FIXED-IN: 24.05
|
|
|
|
|
|
|
|
|
|
* speeds up incremental builds as changes to a header will not always
need the full mocs_compilation.cpp for all the target's headers rebuild,
while having a moc file sourced into a source file only adds minor
extra costs, due to small own code and the used headers usually
already covered by the source file, being for the same class/struct
* seems to not slow down clean builds, due to empty mocs_compilation.cpp
resulting in those quickly processed, while the minor extra cost of the
sourced moc files does not outweigh that in summary.
Measured times actually improved by some percent points.
(ideally CMake would just skip empty mocs_compilation.cpp & its object
file one day)
* enables compiler to see all methods of a class in same compilation unit
to do some sanity checks
* potentially more inlining in general, due to more in the compilation unit
* allows to keep using more forward declarations in the header, as with the
moc code being sourced into the cpp file there definitions can be ensured
and often are already for the needs of the normal class methods
|
|
Better for screen readers etc.
|
|
|
|
|
|
BUG: 364956
BUG: 453211
|
|
|
|
|
|
Refactor and simplify things along the way.
BUG: 457813
|
|
|
|
|
|
|
|
|
|
With this change (plus https://invent.kde.org/frameworks/kio/-/merge_requests/702), slow files will be treated as remote files for generating previews. This should make browsing local mounts of remote locations smoother.
|
|
|
|
BUG: 401170
|
|
|
|
BUG: 430095
BUG: 412902
FIXED-IN: 21.08
|
|
BUG: 434329
FIXED-IN: 21.04
|
|
|
|
|
|
|
|
|
|
|
|
As recommended, we now set `easingCurve` directly.
|
