┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/panels/places/placespanel.cpp
AgeCommit message (Collapse)Author
2018-10-09Added missing icons to panel places itemsAlex Debus
Summary: Screenshots of the changes: | {F6310217} |{F6310218} This contribution was motivated by a comment on [[ https://pointieststick.wordpress.com/2018/10/06/this-week-in-usability-productivity-part-39/comment-page-1/#comment-2108 | Nate's blog]]. Reviewers: #vdg, ngraham Reviewed By: #vdg, ngraham Subscribers: ngraham, acrouthamel, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16019
2018-10-09Added missing QStringLiteral to Dolphin codeAlex Debus
Summary: Changed ``` QIcon::fromTheme("icon") ``` to ``` QIcon::fromTheme(QStringLiteral("edit-entry")) ``` as [[ https://phabricator.kde.org/D16019#339284 | discussed here ]]. Reviewers: ngraham, #dolphin, elvisangelaccio Reviewed By: ngraham, #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16050
2018-10-07Add 'Mount' option to context menu of unmounted device in PlacesThomas Surrel
Summary: This is only a proposal but: 1/ it the sysmetric of the Unmount entry in the context menu of mounted devices 2/ I have to admit it took me a very long time to discover (by accident) that you can just (left-)click on a unmounted device to get it mounted automatically. I might not be the only feeling that you should be able to mount a device from the context menu ... Twin of D15988 in Kio while dolphin is not based on the kio code for Places. {F6306516} Reviewers: #dolphin, #vdg, ngraham, elvisangelaccio Reviewed By: #dolphin, #vdg, ngraham, elvisangelaccio Subscribers: ngraham, acrouthamel, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15974
2018-10-04Change icon for the 'Edit...' context menu entry in Places panelThomas Surrel
Summary: The current icon is used for displaying the Properties context menu in other places in dolphin. Change to edit-entry. Test Plan: Right-click on a place in the Places panel. Reviewers: #dolphin, #vdg, ngraham Reviewed By: #dolphin, #vdg, ngraham Subscribers: broulik, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15938
2018-09-24[Places Panel] Cleanup includesKai Uwe Broulik
Some leftovers from when Dolphin managed the places entirely on its own Differential Revision: https://phabricator.kde.org/D15636
2018-04-01Use QHash rather than QMapElvis Angelaccio
As recommended by the clazy qmap-with-pointer-key check.
2018-03-11Removed unused variables spotted by clazyElvis Angelaccio
2018-03-11Add Trash (empty, isEmpty, emptinessChanged)Roman Inflianskas
Summary: Add `Trash` class to handle all trash operations. Reviewers: elvisangelaccio, markg, ngraham Reviewed By: elvisangelaccio, markg, ngraham Subscribers: ngraham, markg, rkflx, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D11012
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-03Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2017-12-14Implemented support for hide/show groupsRenato Araujo Oliveira Filho
Summary: Added an option on PlacesPanel context menu to show or hide the entire group of places. Depends on D8855 Test Plan: Open Donlphin and use PlacesPanel context menu to hide and show groups Reviewers: franckarrecot, mlaurent, mwolff, elvisangelaccio Reviewed By: franckarrecot, mlaurent, mwolff, elvisangelaccio Subscribers: rkflx, mwolff, elvisangelaccio, ngraham, #dolphin Differential Revision: https://phabricator.kde.org/D9242
2017-12-14Use Kio::KPlacesModel as source model for PlacesItemModelRenato Araujo Oliveira Filho
Summary: Use Kio::KPlacesModel as source model for PlacesItemModel avoiding duplicated code. Depends on D8862 Depends on D8332 Depends on D8434 Depends on D8348 Depends on D8630 Test Plan: Unit test created Reviewers: elvisangelaccio, emmanuelp, mlaurent, mwolff Reviewed By: elvisangelaccio, mlaurent, mwolff Subscribers: mwolff, mlaurent, anthonyfieroni, nicolasfella, ngraham, #dolphin Differential Revision: https://phabricator.kde.org/D8855
2017-11-21Modernize: Use nullptr everywhereKevin Funk
2017-11-03Use nullptr + add explicit keywordMontel Laurent
Test Plan: compile Reviewers: #dolphin, broulik Reviewed By: broulik Subscribers: #dolphin Differential Revision: https://phabricator.kde.org/D8637
2017-10-12Don't block unmounting when terminal panel's cwd is the mountpointMiklos Marton
When unmounting a removable media Dolphin checks if there are some files open on the device before performing the unmount. If the terminal window in dolphin is open and the to be unmounted path is open, the unmount process will be blocked. This patch sets the terminal window current path to the home directory upon unmount request if the terminal directory is set to the mount path. The unmount request could came from two sources: The user could hit right click on the media in the dolphin's places panel and hit unmount. The user could request an unmount from the indicator applet This patch was originally written by Arjun AK for the kdelibs4 version of Dolphin: https://git.reviewboard.kde.org/r/121613/ BUG: 158264 FIXED-IN: 17.11.80 Differential Revision: https://phabricator.kde.org/D7847
2017-09-11Add "Open in New Window to Dolphin's places context menuNathaniel Graham
Summary: BUG: 384352 Add an "Open in New Window" menu item to the context menu for Dolphin's places items. Test Plan: Tested in up-to-date KDE Neon. Works as expected: {F3898707} Reviewers: #dolphin, #kde_applications, dfaure, aacid, elvisangelaccio, emmanuelp, broulik Reviewed By: #dolphin, emmanuelp, broulik Subscribers: alexeymin, emmanuelp, broulik, sefaeyeoglu, #dolphin Tags: #dolphin Differential Revision: https://phabricator.kde.org/D7690
2017-06-27[Places Panel] Disallow editing devicesKai Uwe Broulik
I introduced this bug when I changed the layout of the menu. While it would be nice if one could edit devices, it is currently not possible and would require significant re-engineering effort in Solid. While the "Edit" menu works just fine, changes are not persisted. Reviewed-By: emmanuelp Differential Revision: https://phabricator.kde.org/D6294
2017-03-14Cleanup Places Panel context menusKai Uwe Broulik
Differential Revision: https://phabricator.kde.org/D4498
2016-03-16[CLAZY] Fixed all level 1 and level 2 warnings with small exceptionsArtur Puzio
REVIEW: 126771
2015-02-24Replace kDebug/kWarning by categorized logging (org.kde.dolphin)Emmanuel Pescosta
2015-02-19Merge branch 'master' into frameworksEmmanuel Pescosta
2015-02-19Sync bookmark manager only if the change was done by the current processEmmanuel Pescosta
Adoption of http://commits.kde.org/kdelibs/2b5c6e42fc8114c6854ce490b9cdd4356be683d9 FIXED-IN: 14.12.3 BUG: 343620 BUG: 310080 REVIEW: 122640
2015-01-05Dolphin: port from KonqOperations::doDrop to the new KIO::DropJobDavid Faure
REVIEW: 121678
2014-11-03use QUrl::fromLocalFile() on devicesLukáš Tinkl
fixes being unable to access eg. removable drives
2014-10-21port Dolphin from KUrl to QUrlLukáš Tinkl
REVIEW: 120688
2014-10-18Fix includesMontel Laurent
2014-10-18Fix includesMontel Laurent
2014-10-15Port to QDialogMontel Laurent
2014-10-10Clean includes + port to QMenuMontel Laurent
2014-09-12Ported KIcon to QIconEmmanuel Pescosta
REVIEW: 120159
2014-09-10Merge branch 'master' into frameworksLuca Beltrame
2014-09-02Rename "Recently Accessed" to "Recently Saved"kdeuser 56
In dolphin the Section that leads you to timeline claims to show "Recently Accessed", which is not true, it shows "Recently Saved" instead. BUG: 304854 REVIEW: 119986
2014-08-21Remove KonqOperations::emptyTrash() and port to KIO::emptyTrash() instead.David Faure
2014-06-29Remove the automoc noiseChristophe Giboudeaux
2014-05-13Merge remote-tracking branch 'origin/master' into frameworksFrank Reininghaus
Since the master branch had never been merged into frameworks since the creation of the frameworks branch, I had to fix a couple of merge conflicts and make another change in order to make it build - I hope I did not get anything wrong. We should probably merge master into frameworks on a regular basis from now on. CCMAIL:[email protected] Conflicts: dolphin/src/dolphinmainwindow.cpp dolphin/src/search/dolphinfacetswidget.cpp dolphin/src/statusbar/dolphinstatusbar.cpp dolphin/src/views/dolphinview.cpp
2014-05-05dolphin: convert panels/ and filterbar to qt signal/slot syntaxAlex Richardson
TerminalPanel connections to konsole part were not converted since there is no header available that defines these function, we have to keep the old syntax here. Additionally the new syntax no longer accepts QPointer arguments, we have to explicitly call .data() there.
2014-05-05Allow compiling Dolphin with KF5Alex Richardson
This does not work properly yet, there are probably quite a few bad signal/ slot connections due to KUrl -> QUrl. However dolphin starts without crashing. Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5 and I have no idea how it is supposed to be used. This is the first commit for review 117395
2014-04-26Mount partitions when you open them in a new tab.Emmanuel Pescosta
Instead of just emitting the slotItemMiddleClicked signal in PlacesPanel::slotItemContextMenuRequested we now use triggerItem with Qt::MiddleButton, which does set up the storage first and emit the slotItemMiddleClicked signal afterwards. BUG: 311226 FIXED-IN: 4.13.1 REVIEW: 117755
2013-05-28PlacesPanel: Do not allow drop events into timeline or search folderVishesh Handa
They are read only. You cannot modify them, so it makes no point showing the "Move/Copy Into" context menu. REVIEW: 110348
2013-02-19Merge remote-tracking branch 'origin/KDE/4.10'Frank Reininghaus
Conflicts: dolphin/src/tests/kfileitemmodeltest.cpp lib/konq/konq_operations.cpp
2013-02-18Fix crash when clicking an action in context menu for a removed deviceFrank Reininghaus
Devices can be added and removed while the context menu is open. Sfter an action has clicked that needs to access a device, we therefore have to check if its position in the model has changed, and more importantly, if it is still there at all in order to prevent a crash. BUG: 315298 FIXED-IN: 4.10.1 REVIEW: 108989
2013-02-10Merge remote-tracking branch 'origin/KDE/4.10'Frank Reininghaus
2013-02-05Apply changes of the KGlobalSettings::singleClick() setting immediatelyAniket Anvit
Fixes a regression introduced by commit 7a364cbf489af25e123d18713523151a3a53f814. Patch reviewed and pushed by Frank Reininghaus. BUG: 313342 FIXED-IN: 4.10.1
2013-01-09Fix Bug 233335 - Wrong icons selected after pasting files and renaming them ↵Emmanuel Pescosta
(because there exists items with it's names Fixed the "same" buggy behavior when dropping files/folders Select also putted files (PUT operation - SimpleJob) - e.g. Paste content from clipboard BUG: 233335 REVIEW: 107351
2012-11-04Use the standard sizes from KIconLoader, rather than hardcoded sizes.Frank Reininghaus
2012-11-01Add an "Icon Size" submenu to the context menu of the Places PanelFrank Reininghaus
FEATURE: 307475 FIXED-IN: 4.10.0 CCBUG: 301959
2012-09-27Merge branch '4.9'Dawit Alemayehu
2012-09-27Add a new config option for the icon size in the Places PanelFrank Reininghaus
To change the icon size in the Places Panel to, e.g., 60 pixels, add the following lines to $KDEHOME/share/config/dolphinrc : [PlacesPanel] IconSize=60 A value of -1 means that the standard "Small" size should be used (which has been the default before this commit). It is planned to add an "Icon Size" submenu to the context menu of the Places Panel in KDE 4.10, but we cannot do this in the 4.9 branch because of the string freeze. FIXED-IN: 4.9.2 BUG: 301959
2012-09-11Mount unmounted devices, when a file is dropped upon it in places-panel.Emmanuel Pescosta
BUG: 176277 REVIEW: 106072 FIXED-IN: 4.9.2 (cherry picked from commit 824fa6a43734cf9ad2a690778c50bdaf76a1fb0e)
2012-09-11Mount unmounted devices, when a file is dropped upon it in places-panel.Emmanuel Pescosta
BUG: 176277 REVIEW: 106072
generated by cgit v1.3 (git 2.53.0) at 2026-04-18 07:49:10 +0000